Re: [PATCH v2 06/20] nvme: Fix reservation status related structs

Chaitanya Kulkarni
2022-08-09T11:09:27Z

On 8/9/22 00:19, Christoph Hellwig wrote:
> On Mon, Aug 08, 2022 at 07:04:05PM -0500, Mike Christie wrote:
>> This fixes the following issues with the reservation status structs:
>>
>> 1. resv10 is bytes 23:10 so it should be 14 bytes.
>> 2. regctl_ds only supports 64 bit host IDs.
>
> This doesn't actually seem to be used by the kernel at all. Which
> I guess means I need to go back into my todo list and tackle the
> discussion if we want to have non-kernel bits in nvme.h to start
> with.

Having non-kernel bits in nvme.h creates confusion, I've raised this
question in past, in case old nvme-cli (without libnvme) was the
reason to keep them in kernel maybe we can sort this out since
now that nvme-cli and libnvme are spilt ?

-ck