Re: [PATCH v2 04/20] scsi: Add support for block PR read keys/reservation.

Bart Van Assche
2022-08-09T19:26:33Z

On 8/8/22 17:04, Mike Christie wrote:
> +static int sd_pr_in_command(struct block_device *bdev, u8 sa,
> + unsigned char *data, int data_len)
> +{
> + struct scsi_disk *sdkp = scsi_disk(bdev->bd_disk);
> + struct scsi_device *sdev = sdkp->device;
> + struct scsi_sense_hdr sshdr;
> + u8 cmd[10] = { 0, };
> + int result;

Isn't "{ }" instead of "{ 0, }" the preferred way to zero-initialize a
data structure?

> +
> + cmd[0] = PERSISTENT_RESERVE_IN;
> + cmd[1] = sa;

Can the above two assignments be moved into the initializer of cmd[]?

Thanks,

Bart.