Re: [PATCH v2 09/20] nvme: Add helper to execute Reservation Report

Mike Christie
2022-08-09T16:18:29Z

On 8/9/22 5:55 AM, Chaitanya Kulkarni wrote:
> On 8/8/22 17:04, Mike Christie wrote:
>> This adds a helper to execute the Reservation Report. The next patches
>> will then convert call it and convert that info to read_keys and
>> read_reservation.
>>
>> Signed-off-by: Mike Christie <michael.christie@oracle.com>
>> ---
>> drivers/nvme/host/core.c | 27 +++++++++++++++++++++++++++
>> 1 file changed, 27 insertions(+)
>>
>
> from the comments I've received in the past, please add a function
> in the patch where it is actually using it.
>

For your comment and Christoph's comment I'll merge patch 8 - 11 together
so the helpers and users are together.

> Also, please consider if we can move pr code into its separate file
> if others are okay with it as host/core.c file is getting bigger.
>

Ok.