From: "Peter Wang (王信友)" <peter.wang@mediatek.com>
To: "beanhuo@micron.com" <beanhuo@micron.com>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"quic_rampraka@quicinc.com" <quic_rampraka@quicinc.com>,
"quic_cang@quicinc.com" <quic_cang@quicinc.com>,
"quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
"quic_nitirawa@quicinc.com" <quic_nitirawa@quicinc.com>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"quic_ziqichen@quicinc.com" <quic_ziqichen@quicinc.com>,
"junwoo80.lee@samsung.com" <junwoo80.lee@samsung.com>,
"mani@kernel.org" <mani@kernel.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "ahalaney@redhat.com" <ahalaney@redhat.com>,
"ebiggers@google.com" <ebiggers@google.com>,
"neil.armstrong@linaro.org" <neil.armstrong@linaro.org>,
"chu.stanley@gmail.com" <chu.stanley@gmail.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"manivannan.sadhasivam@linaro.org"
<manivannan.sadhasivam@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"minwoo.im@samsung.com" <minwoo.im@samsung.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v4 1/8] scsi: ufs: core: Pass target_freq to clk_scale_notify() vop
Date: Tue, 11 Feb 2025 03:52:13 +0000 [thread overview]
Message-ID: <6dc8849886ff4ac6ceca7d8e36b853b27f337cb9.camel@mediatek.com> (raw)
In-Reply-To: <20250210100212.855127-2-quic_ziqichen@quicinc.com>
On Mon, 2025-02-10 at 18:02 +0800, Ziqi Chen wrote:
>
> diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h
> index d7aca9e61684..f51d425696e7 100644
> --- a/include/ufs/ufshcd.h
> +++ b/include/ufs/ufshcd.h
> @@ -344,8 +344,8 @@ struct ufs_hba_variant_ops {
> void (*exit)(struct ufs_hba *);
> u32 (*get_ufs_hci_version)(struct ufs_hba *);
> int (*set_dma_mask)(struct ufs_hba *);
> - int (*clk_scale_notify)(struct ufs_hba *, bool,
> - enum ufs_notify_change_status);
> + int (*clk_scale_notify)(struct ufs_hba *, bool, unsigned
> long,
> + enum
> ufs_notify_change_status);
>
Hi Ziqi,
Please keep the identation consistent.
Thanks.
Peter
> int (*setup_clocks)(struct ufs_hba *, bool,
> enum ufs_notify_change_status);
> int (*hce_enable_notify)(struct ufs_hba *,
> --
> 2.34.1
>
next prev parent reply other threads:[~2025-02-11 3:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 10:02 [PATCH v4 0/8] Support Multi-frequency scale for UFS Ziqi Chen
2025-02-10 10:02 ` [PATCH v4 1/8] scsi: ufs: core: Pass target_freq to clk_scale_notify() vop Ziqi Chen
2025-02-11 3:52 ` Peter Wang (王信友) [this message]
2025-02-11 10:04 ` Ziqi Chen
2025-02-10 10:02 ` [PATCH v4 2/8] scsi: ufs: qcom: Pass target_freq to clk scale pre and post change Ziqi Chen
2025-02-10 10:02 ` [PATCH v4 3/8] scsi: ufs: core: Add a vop to map clock frequency to gear speed Ziqi Chen
2025-02-11 6:02 ` Peter Wang (王信友)
2025-02-11 10:14 ` Ziqi Chen
2025-02-10 10:02 ` [PATCH v4 4/8] scsi: ufs: qcom: Implement the freq_to_gear_speed() vop Ziqi Chen
2025-02-10 10:02 ` [PATCH v4 5/8] scsi: ufs: core: Enable multi-level gear scaling Ziqi Chen
2025-02-11 9:28 ` Peter Wang (王信友)
2025-02-11 10:28 ` Ziqi Chen
2025-02-10 10:02 ` [PATCH v4 6/8] scsi: ufs: core: Check if scaling up is required when disable clkscale Ziqi Chen
2025-02-10 18:17 ` Bean Huo
2025-02-11 12:58 ` Peter Wang (王信友)
2025-02-10 10:02 ` [PATCH v4 7/8] scsi: ufs: core: Toggle Write Booster during clock scaling base on gear speed Ziqi Chen
2025-02-11 12:59 ` Peter Wang (王信友)
2025-02-10 10:02 ` [PATCH v4 8/8] ABI: sysfs-driver-ufs: Add missing UFS sysfs attributes Ziqi Chen
2025-02-10 18:24 ` Bean Huo
2025-02-13 7:55 ` Ziqi Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dc8849886ff4ac6ceca7d8e36b853b27f337cb9.camel@mediatek.com \
--to=peter.wang@mediatek.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=ahalaney@redhat.com \
--cc=alim.akhtar@samsung.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=chu.stanley@gmail.com \
--cc=ebiggers@google.com \
--cc=junwoo80.lee@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=minwoo.im@samsung.com \
--cc=neil.armstrong@linaro.org \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_rampraka@quicinc.com \
--cc=quic_ziqichen@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox