Re: [PATCH V5 11/11] scsi: ufs: qcom: Prevent calling phy_exit before phy_init

Nitin Rawat
2025-05-21T22:22:06Z

On 5/21/2025 7:35 PM, Manivannan Sadhasivam wrote:
> On Thu, May 15, 2025 at 09:57:22PM +0530, Nitin Rawat wrote:
>> Prevent calling phy_exit before phy_init to avoid abnormal power
>> count and the following warning during boot up.
>>
>> [5.146763] phy phy-1d80000.phy.0: phy_power_on was called before phy_init
>>
>> Fixes: 7bac65687510 ("scsi: ufs: qcom: Power off the PHY if it was already powered on in ufs_qcom_power_up_sequence()")
>> Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>
>
> You should move this fix to the start of the series so that it can be applied
> separately if needed and also to be backported cleanly.

sure , will move

>
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> ---
>> drivers/ufs/host/ufs-qcom.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
>> index 583db910efd4..bd7f65500db7 100644
>> --- a/drivers/ufs/host/ufs-qcom.c
>> +++ b/drivers/ufs/host/ufs-qcom.c
>> @@ -540,7 +540,6 @@ static int ufs_qcom_power_up_sequence(struct ufs_hba *hba)
>>
>> if (phy->power_count) {
>> ufs_qcom_phy_power_off(hba);
>> - phy_exit(phy);
>> }
>
> You don't need braces now.
will remove.
>
> - Mani
>