From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 937ABC47096 for ; Thu, 3 Jun 2021 15:43:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 667F1613BF for ; Thu, 3 Jun 2021 15:43:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229726AbhFCPpA (ORCPT ); Thu, 3 Jun 2021 11:45:00 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:3150 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229617AbhFCPo7 (ORCPT ); Thu, 3 Jun 2021 11:44:59 -0400 Received: from fraeml706-chm.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Fwqbn6J8pz6J8kh; Thu, 3 Jun 2021 23:30:45 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml706-chm.china.huawei.com (10.206.15.55) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 3 Jun 2021 17:43:13 +0200 Received: from [10.47.80.115] (10.47.80.115) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 3 Jun 2021 16:43:13 +0100 Subject: Re: [PATCH 0/4] scsi: fix failure handling of alloc/add host To: Ming Lei , "Martin K . Petersen" , CC: Bart Van Assche , Hannes Reinecke References: <20210602133029.2864069-1-ming.lei@redhat.com> From: John Garry Message-ID: <6fb17d5f-d266-58b8-40be-eae970f84e47@huawei.com> Date: Thu, 3 Jun 2021 16:43:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20210602133029.2864069-1-ming.lei@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.80.115] X-ClientProxiedBy: lhreml751-chm.china.huawei.com (10.201.108.201) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 02/06/2021 14:30, Ming Lei wrote: > Hello Martin, > > Fix failure handling of alloc/add host code, and related device release > handling. > > > Ming Lei (4): > scsi: core: fix error handling of scsi_host_alloc > scsi: core: fix failure handling of scsi_add_host_with_dma > scsi: core: put .shost_dev in failure path if host state becomes > running > scsi: core: only put parent device if host state isn't in > SHOST_CREATED > > drivers/scsi/hosts.c | 47 ++++++++++++++++++++++++-------------------- > 1 file changed, 26 insertions(+), 21 deletions(-) > > Cc: Bart Van Assche > Cc: John Garry > Cc: Hannes Reinecke > I tested a single error path in each of scsi_host_alloc() and scsi_add_host_with_dma(), and it looked ok, so: Tested-by: John Garry