From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 0/2] scsi: core: regression fixes for request batching Date: Wed, 7 Aug 2019 18:17:10 +0200 Message-ID: <700f3175-561a-c577-0cb7-3f9ae4d82db0@redhat.com> References: <20190807144948.28265-1-maier@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190807144948.28265-1-maier@linux.ibm.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Steffen Maier , "James E . J . Bottomley" , "Martin K . Petersen" , Ming Lei Cc: Jens Axboe , linux-s390@vger.kernel.org, Benjamin Block , Vasily Gorbik , linux-scsi@vger.kernel.org, Mike Snitzer , Heiko Carstens , Hannes Reinecke , "Ewan D . Milne" , linux-block@vger.kernel.org, dm-devel@redhat.com, linux-next@vger.kernel.org, Christoph Hellwig , Bart Van Assche List-Id: linux-scsi@vger.kernel.org On 07/08/19 16:49, Steffen Maier wrote: > Hi James, Martin, Paolo, Ming, > > multipathing with linux-next is broken since 20190723 in our CI. > The patches fix a memleak and a severe dh/multipath functional regression. > It would be nice if we could get them to 5.4/scsi-queue and also next. > > I would have preferred if such a new feature had used its own > new copy scsi_mq_ops_batching instead of changing the use case and > semantics of the existing scsi_mq_ops, because this would likely > cause less regressions for all the other users not using the new feature. > > Steffen Maier (2): > scsi: core: fix missing .cleanup_rq for SCSI hosts without request > batching > scsi: core: fix dh and multipathing for SCSI hosts without request > batching > > drivers/scsi/scsi_lib.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Paolo Bonzini From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 836A6C32751 for ; Wed, 7 Aug 2019 16:17:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 64E4222387 for ; Wed, 7 Aug 2019 16:17:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389001AbfHGQRR (ORCPT ); Wed, 7 Aug 2019 12:17:17 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:37249 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388257AbfHGQRR (ORCPT ); Wed, 7 Aug 2019 12:17:17 -0400 Received: by mail-wr1-f67.google.com with SMTP id b3so864705wro.4 for ; Wed, 07 Aug 2019 09:17:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rimRfJuK8em3IqAQSX92nJpilfNEDReWvsTTczdkS5I=; b=P3Gpg+URgFYl8Sfdwpk2uCd6LpS4afhd9A7Y58guJt2XpF4ojbTmsQf+mr2JZ/O3R1 7RvHwhojOwgdx0zgtoSHQJFhOGhW4vdkQ0sSLFv0IU/7cMZN2edBQWFl7Ry5o4/9jrog YPSk/b7bzs9+uzM/YDXvmzMh4IiCdxGk+IaYTrNHBvWeqcm40vpoRy+WeZonvE+krt4s /AKuyO95q2vWpI/KB4nJhOrXsJJ5CmfwEFMWI7F1MY//pQF6WuG9kQrFPrMR52Jwp39u eLwS4mDyC2t1eX3cLDMMZ4lC60r+bN8+UmYLZMtZ3GWkDKaaLop7wOSePOW4IA4BOsTC vVog== X-Gm-Message-State: APjAAAW5knYVglF8+0MtQHenfY89JL01XKqqmeS6ZWh3ydDLjct7jN4q NwcItzy1FbLmSEtJ5ZssJsphoA== X-Google-Smtp-Source: APXvYqzazjaE77Dv6t5Ci6gVHioOlkD24Kr5pc/9tKvr9Hj/6DlaId/9yHdHHf/uwryHMeAikdLuZA== X-Received: by 2002:a5d:6606:: with SMTP id n6mr4280889wru.346.1565194635282; Wed, 07 Aug 2019 09:17:15 -0700 (PDT) Received: from [192.168.10.150] ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id f10sm79635116wrs.22.2019.08.07.09.17.11 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 07 Aug 2019 09:17:14 -0700 (PDT) Subject: Re: [PATCH 0/2] scsi: core: regression fixes for request batching To: Steffen Maier , "James E . J . Bottomley" , "Martin K . Petersen" , Ming Lei Cc: linux-next@vger.kernel.org, linux-scsi@vger.kernel.org, linux-block@vger.kernel.org, dm-devel@redhat.com, linux-s390@vger.kernel.org, Benjamin Block , Heiko Carstens , Vasily Gorbik , Bart Van Assche , Hannes Reinecke , Jens Axboe , "Ewan D . Milne" , Christoph Hellwig , Mike Snitzer References: <20190807144948.28265-1-maier@linux.ibm.com> From: Paolo Bonzini Openpgp: preference=signencrypt Message-ID: <700f3175-561a-c577-0cb7-3f9ae4d82db0@redhat.com> Date: Wed, 7 Aug 2019 18:17:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190807144948.28265-1-maier@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Message-ID: <20190807161710.PmTTX3oHG6eT8MF5y1pKOTrxhta9OwWNhzK783J0WjI@z> On 07/08/19 16:49, Steffen Maier wrote: > Hi James, Martin, Paolo, Ming, > > multipathing with linux-next is broken since 20190723 in our CI. > The patches fix a memleak and a severe dh/multipath functional regression. > It would be nice if we could get them to 5.4/scsi-queue and also next. > > I would have preferred if such a new feature had used its own > new copy scsi_mq_ops_batching instead of changing the use case and > semantics of the existing scsi_mq_ops, because this would likely > cause less regressions for all the other users not using the new feature. > > Steffen Maier (2): > scsi: core: fix missing .cleanup_rq for SCSI hosts without request > batching > scsi: core: fix dh and multipathing for SCSI hosts without request > batching > > drivers/scsi/scsi_lib.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Paolo Bonzini