From: Douglas Gilbert <dgilbert@interlog.com>
To: Dan Carpenter <dan.carpenter@oracle.com>, Hannes Reinecke <hare@suse.de>
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: sg: off by one in sg_ioctl()
Date: Tue, 22 Aug 2017 21:50:23 -0400 [thread overview]
Message-ID: <7356ab9f-1f9e-e879-8c95-52caa6802ca4@interlog.com> (raw)
In-Reply-To: <20170817070954.d4gg7hqgg2qjf6d3@mwanda>
On 2017-08-17 03:09 AM, Dan Carpenter wrote:
> If "val" is SG_MAX_QUEUE then we are one element beyond the end of the
> "rinfo" array so the > should be >=.
>
> Fixes: 109bade9c625 ("scsi: sg: use standard lists for sg_requests")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Douglas Gilbert <dgilbert@interlog.com>
Thanks.
>
> diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
> index d7ff71e0c85c..84e782d8e7c3 100644
> --- a/drivers/scsi/sg.c
> +++ b/drivers/scsi/sg.c
> @@ -1021,7 +1021,7 @@ sg_ioctl(struct file *filp, unsigned int cmd_in, unsigned long arg)
> read_lock_irqsave(&sfp->rq_list_lock, iflags);
> val = 0;
> list_for_each_entry(srp, &sfp->rq_list, entry) {
> - if (val > SG_MAX_QUEUE)
> + if (val >= SG_MAX_QUEUE)
> break;
> memset(&rinfo[val], 0, SZ_SG_REQ_INFO);
> rinfo[val].req_state = srp->done + 1;
>
next prev parent reply other threads:[~2017-08-23 1:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 7:09 [PATCH] scsi: sg: off by one in sg_ioctl() Dan Carpenter
2017-08-23 1:50 ` Douglas Gilbert [this message]
2017-08-23 2:24 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7356ab9f-1f9e-e879-8c95-52caa6802ca4@interlog.com \
--to=dgilbert@interlog.com \
--cc=dan.carpenter@oracle.com \
--cc=hare@suse.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox