public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: "Zephaniah E. Loss-Cutler-Hull" <warp@aehallh.com>,
	"Zephaniah E. Loss-Cutler-Hull" <warp-spam_kernel@aehallh.com>,
	linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
	linux-scsi@vger.kernel.org
Cc: Paolo Valente <paolo.valente@linaro.org>
Subject: Re: General protection fault with use_blk_mq=1.
Date: Wed, 28 Mar 2018 21:22:47 -0600	[thread overview]
Message-ID: <735c5d75-eacf-8ed2-ba9b-9ff4b0b5290d@kernel.dk> (raw)
In-Reply-To: <b347896e-f770-8987-ad90-a595a5fa926a@aehallh.com>

On 3/28/18 9:13 PM, Zephaniah E. Loss-Cutler-Hull wrote:
> On 03/28/2018 06:02 PM, Jens Axboe wrote:
>> On 3/28/18 5:03 PM, Zephaniah E. Loss-Cutler-Hull wrote:
>>> I am not subscribed to any of the lists on the To list here, please CC
>>> me on any replies.
>>>
>>> I am encountering a fairly consistent crash anywhere from 15 minutes to
>>> 12 hours after boot with scsi_mod.use_blk_mq=1 dm_mod.use_blk_mq=1> 
>>> The crash looks like:
>>>
> 
>>>
>>> Looking through the code, I'd guess that this is dying inside
>>> blkg_rwstat_add, which calls percpu_counter_add_batch, which is what RIP
>>> is pointing at.
>>
>> Leaving the whole thing here for Paolo - it's crashing off insertion of
>> a request coming out of SG_IO. Don't think we've seen this BFQ failure
>> case before.
>>
>> You can mitigate this by switching the scsi-mq devices to mq-deadline
>> instead.
>>
> 
> I'm thinking that I should also be able to mitigate it by disabling
> CONFIG_DEBUG_BLK_CGROUP.
> 
> That should remove that entire chunk of code.
> 
> Of course, that won't help if this is actually a symptom of a bigger
> problem.

Yes, it's not a given that it will fully mask the issue at hand. But
turning off BFQ has a much higher chance of working for you.

This time actually CC'ing Paolo.


-- 
Jens Axboe

  reply	other threads:[~2018-03-29  3:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-28 23:03 General protection fault with use_blk_mq=1 Zephaniah E. Loss-Cutler-Hull
2018-03-29  1:02 ` Jens Axboe
2018-03-29  3:13   ` Zephaniah E. Loss-Cutler-Hull
2018-03-29  3:22     ` Jens Axboe [this message]
2018-03-29  5:13       ` Paolo Valente
2018-03-29  9:12         ` Zephaniah E. Loss-Cutler-Hull
2018-03-30  5:43           ` Zephaniah E. Loss-Cutler-Hull
2018-03-29  4:56   ` Paolo Valente

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=735c5d75-eacf-8ed2-ba9b-9ff4b0b5290d@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=paolo.valente@linaro.org \
    --cc=warp-spam_kernel@aehallh.com \
    --cc=warp@aehallh.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox