From: Bart Van Assche <bvanassche@acm.org>
To: James Wang <jnwang@linux.alibaba.com>,
don.brace@microsemi.com, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com, esc.storagedev@microsemi.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] [hpsa] Fix the wrong chars in comment section
Date: Tue, 15 Feb 2022 09:37:45 -0800 [thread overview]
Message-ID: <739e4ca0-ec2d-d39a-4c80-2b2e16435f49@acm.org> (raw)
In-Reply-To: <1644889961-61470-1-git-send-email-jnwang@linux.alibaba.com>
On 2/14/22 17:52, James Wang wrote:
> These '+' should be redundant.
>
> Signed-off-by: James Wang <jnwang@linux.alibaba.com>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Please do NOT add a Reviewed-by tag if a reviewer has not posted that
tag himself.
I have the following additional comments on this patch:
- I am not convinced that this patch is useful since it does not help
users of the hpsa driver.
- The comment still does not conform to the Linux kernel coding style.
From coding-style.rst:
The preferred style for long (multi-line) comments is:
.. code-block:: c
/*
* This is the preferred style for multi-line
* comments in the Linux kernel source code.
* Please use it consistently.
*
* Description: A column of asterisks on the left side,
* with beginning and ending almost-blank lines.
*/
Bart.
next prev parent reply other threads:[~2022-02-15 17:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-13 8:59 [PATCH] [hpsa] Fix the wrong chars in comment section James Wang
2022-02-14 16:51 ` Bart Van Assche
2022-02-15 1:52 ` [PATCH v2] " James Wang
2022-02-15 17:37 ` Bart Van Assche [this message]
2022-02-22 7:28 ` James Wang
2022-02-23 2:38 ` [PATCH v3] [hpsa] Improve the coding-style to comment sections James Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=739e4ca0-ec2d-d39a-4c80-2b2e16435f49@acm.org \
--to=bvanassche@acm.org \
--cc=don.brace@microsemi.com \
--cc=esc.storagedev@microsemi.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jnwang@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox