From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D219C4332F for ; Thu, 2 Nov 2023 07:26:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233093AbjKBH0B (ORCPT ); Thu, 2 Nov 2023 03:26:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229675AbjKBH0A (ORCPT ); Thu, 2 Nov 2023 03:26:00 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB380133; Thu, 2 Nov 2023 00:25:54 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9E4962187D; Thu, 2 Nov 2023 07:25:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1698909953; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j2fJUx5ZlL0GCbBxsPWv5OxSZiq5J9Xq+Hw295A1mqk=; b=CmIk56NNfv5e+ppr1EJvVgMcOBQFwqtHrYQxWuPcA6niNshV0r/VQGKqT51GrRDuHhQph7 BFwJ317/bVE3XzEig27ye+C+m1zBfTzH6KfNqI5/stHQW1+UzaKadI4mrkat4C7fHQF+EF FJkNzS41gq0Utt8OoGelNhs61GqhzOo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1698909953; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j2fJUx5ZlL0GCbBxsPWv5OxSZiq5J9Xq+Hw295A1mqk=; b=cIMWBLQfbvf1+rnzXG73PC6//kQtGeZmkquKlcVg3cQCwT1I7+aOaVZR2X2jM7t9muhuTb 1OPmjjnuiFWa+hDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 516ED138EC; Thu, 2 Nov 2023 07:25:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id HTwxEgFPQ2URMAAAMHmgww (envelope-from ); Thu, 02 Nov 2023 07:25:53 +0000 Message-ID: <7526d690-1deb-4611-92ef-a3707ebd60a5@suse.de> Date: Thu, 2 Nov 2023 08:25:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/13] scsi: fnic: Add and use fnic number Content-Language: en-US To: Karan Tilak Kumar , sebaddel@cisco.com Cc: arulponn@cisco.com, djhawar@cisco.com, gcboffa@cisco.com, mkai2@cisco.com, satishkh@cisco.com, jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231027180302.418676-1-kartilak@cisco.com> <20231027180302.418676-3-kartilak@cisco.com> From: Hannes Reinecke In-Reply-To: <20231027180302.418676-3-kartilak@cisco.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 10/27/23 20:02, Karan Tilak Kumar wrote: > Add fnic_num in fnic.h to identify fnic in a multi-fnic environment. > Increment and set the fnic number during driver load in fnic_probe. > Replace the host number with fnic number in debugfs. > > Reviewed-by: Sesidhar Baddela > Reviewed-by: Arulprabhu Ponnusamy > Signed-off-by: Karan Tilak Kumar > --- > drivers/scsi/fnic/fnic.h | 1 + > drivers/scsi/fnic/fnic_debugfs.c | 2 +- > drivers/scsi/fnic/fnic_main.c | 6 +++++- > 3 files changed, 7 insertions(+), 2 deletions(-) > Why? The scsi host number gives you a perfectly good enumeration. And really all you do is replacing the scsi host number with an internal number, with no change in functionality. Why? Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman