From: "Justin T. Gibbs" <gibbs@scsiguy.com>
To: James Bottomley <James.Bottomley@steeleye.com>
Cc: Rik van Riel <riel@conectiva.com.br>,
Tomas Szepe <szepe@pinerecords.com>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
Samuel Flory <sflory@rackable.com>,
Janet Morgan <janetmor@us.ibm.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] aic7xxx bouncing over 4G
Date: Sat, 28 Dec 2002 14:02:17 -0700 [thread overview]
Message-ID: <775808112.1041109337@aslan.scsiguy.com> (raw)
In-Reply-To: <200212282016.gBSKGrF03354@localhost.localdomain>
> gibbs@scsiguy.com said:
>> That hasn't applied since 6.2.10 or so. 2.5.X is still using 6.2.4.
>
> The bug report is against 2.5.53 which has 6.2.24 in it, so it still
> needs fixing. At a cursory glance at the code, it looks like you don't
> call scsi_set_pci_device early enough in the detect routine.
I don't see how this enters into it. The dma mask should be set on
the PCI device in aic7xxx_osm_pci.c just after we enable the device
and set it as a bus master. The pci device is setup in the host
structure as it is allocated and before it is registered with the
SCSI subsystem. I can't imagine that the merge function (and thereby
the bounce limit) is selected before the host is even registered.
My guess is that the original call to setup the PCI mask is not happening
due to either a logic bug in ahc_linux_get_memsize() or the logic that
interprets its response in aic7xxx_osm_pci.c.
I'm not in front of a Linux system to debug this, so all I can do is
inspect the code right now. Perhaps someone with an affected machine
can toss in a few printks and figure this out?
--
Justin
next prev parent reply other threads:[~2002-12-28 21:02 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-21 0:12 [PATCH] aic7xxx bouncing over 4G Janet Morgan
2002-12-21 0:23 ` Justin T. Gibbs
2002-12-21 0:29 ` William Lee Irwin III
2002-12-21 0:59 ` Justin T. Gibbs
2002-12-21 1:35 ` William Lee Irwin III
2002-12-21 1:59 ` Justin T. Gibbs
2002-12-21 4:10 ` David S. Miller
2002-12-21 15:19 ` Justin T. Gibbs
2002-12-21 21:41 ` David S. Miller
2002-12-21 7:10 ` Erik Andersen
2002-12-21 15:23 ` Justin T. Gibbs
2002-12-21 8:55 ` Christoph Hellwig
2002-12-21 15:30 ` Justin T. Gibbs
2002-12-21 17:45 ` Doug Ledford
2002-12-22 0:16 ` Linus Torvalds
2002-12-21 0:51 ` Samuel Flory
2002-12-28 5:32 ` Marcelo Tosatti
2002-12-28 9:16 ` Tomas Szepe
2002-12-28 13:33 ` Rik van Riel
2002-12-28 13:40 ` Tomas Szepe
2002-12-28 16:23 ` Tony Spinillo
2002-12-28 15:00 ` James Bottomley
2002-12-28 19:16 ` Justin T. Gibbs
2002-12-28 20:16 ` James Bottomley
2002-12-28 21:02 ` Justin T. Gibbs [this message]
2002-12-28 20:18 ` Andrew Morton
2002-12-28 20:50 ` Justin T. Gibbs
2002-12-28 22:24 ` James Bottomley
2002-12-28 22:31 ` Justin T. Gibbs
2002-12-28 22:46 ` Andrew Morton
2002-12-28 19:13 ` Justin T. Gibbs
2002-12-28 19:19 ` Rik van Riel
2002-12-28 19:42 ` Doug Ledford
2002-12-28 21:04 ` Willy Tarreau
2002-12-28 22:37 ` David Lang
2002-12-29 12:54 ` Arjan van de Ven
2003-01-03 15:28 ` Justin T. Gibbs
2003-01-06 1:40 ` aic79xx bug? my stupidity? Roberto Peon
2003-01-06 1:46 ` Justin T. Gibbs
2002-12-30 21:06 ` [PATCH] aic7xxx bouncing over 4G Samuel Flory
2002-12-28 9:50 ` Christoph Hellwig
2002-12-30 1:23 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=775808112.1041109337@aslan.scsiguy.com \
--to=gibbs@scsiguy.com \
--cc=James.Bottomley@steeleye.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=janetmor@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=riel@conectiva.com.br \
--cc=sflory@rackable.com \
--cc=szepe@pinerecords.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox