From: "Liang He" <windhl@126.com>
To: "Bart Van Assche" <bvanassche@acm.org>
Cc: jejb@linux.ibm.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org
Subject: Re:Re: [PATCH v2] ufs: host: ufschd-pltfrm: Hold reference returned by of_parse_phandle()
Date: Wed, 20 Jul 2022 08:48:06 +0800 (CST) [thread overview]
Message-ID: <77c15dc7.730.1821913894e.Coremail.windhl@126.com> (raw)
In-Reply-To: <554f38b5-8506-2ab3-dbff-bcc18b00000f@acm.org>
At 2022-07-20 02:12:36, "Bart Van Assche" <bvanassche@acm.org> wrote:
>On 7/18/22 19:46, Liang He wrote:
>> Can you help me as I have a trouble about the indentation.
>>
>> When I align descendants to a function open parenthesis in VIM editor,
>> but when I generate the patch, I find the second line always missing one space in
>> patch format. So is there any problem if I send this patch?
>>
>> I make sure that the alignment in VIM is OK.
>
>Hi Liang,
>
>Please don't worry about this. When a code change is converted into a
>patch, a single character is inserted at the start of each line (plus,
>minus or space). That makes code that is indented with tabs look weird.
>This is normal.
>
>Bart.
Thanks very much for all your help and your effort to review my code.
Liang
prev parent reply other threads:[~2022-07-20 0:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 0:17 [PATCH v2] ufs: host: ufschd-pltfrm: Hold reference returned by of_parse_phandle() Liang He
2022-07-16 13:50 ` Bart Van Assche
2022-07-17 3:03 ` Liang He
2022-07-17 14:58 ` Bart Van Assche
2022-07-18 8:30 ` Liang He
2022-07-19 2:46 ` Liang He
2022-07-19 18:12 ` Bart Van Assche
2022-07-20 0:48 ` Liang He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77c15dc7.730.1821913894e.Coremail.windhl@126.com \
--to=windhl@126.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox