From: ygardi@codeaurora.org
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Yaniv Gardi <ygardi@codeaurora.org>,
james.bottomley@hansenpartnership.com, kishon@ti.com,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-arm-msm@vger.kernel.org, santoshsy@gmail.com,
linux-scsi-owner@vger.kernel.org, subhashj@codeaurora.org,
gbroner@codeaurora.org, dovl@codeaurora.org,
Vinayak Holikatti <vinholikatti@gmail.com>,
"James E.J. Bottomley" <jbottomley@odin.com>
Subject: Re: [PATCH v1 2/3] scsi: ufs-qcom: fix compilation warning if compiled as a module
Date: Wed, 20 May 2015 13:49:50 -0000 [thread overview]
Message-ID: <77d452918f9dad547ddf728022f82fb0.squirrel@www.codeaurora.org> (raw)
In-Reply-To: <1432110592.21715.50.camel@x220>
> On Tue, 2015-05-19 at 16:47 +0300, Yaniv Gardi wrote:
>> --- a/drivers/scsi/ufs/ufs-qcom.c
>> +++ b/drivers/scsi/ufs/ufs-qcom.c
>> @@ -885,7 +885,7 @@ out:
>>
>> #define ANDROID_BOOT_DEV_MAX 30
>> static char android_boot_dev[ANDROID_BOOT_DEV_MAX];
>> -static int get_android_boot_dev(char *str)
>> +static int __maybe_unused get_android_boot_dev(char *str)
>> {
>> strlcpy(android_boot_dev, str, ANDROID_BOOT_DEV_MAX);
>> return 1;
>
> Wouldn't it be clearer to wrap these few lines (until after the
> __setup() macro) with #ifndef MODULE?
>
> And I think get_android_boot_dev() could be marked __init. Because if
> it's built-in it will never be called after the kernel has finished
> booting, right?
>
That's correct. I will upload an update to this patch.
I accept both comments
#ifndef MODULE is indeed clearer
and __init flag as well, since get_android_boot_dev() will not be called
again after booting finished.
>
> Paul Bolle
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2015-05-20 13:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 13:47 [PATCH v1 0/3] fixing building errors and warnings when components Yaniv Gardi
2015-05-19 13:47 ` [PATCH v1 1/3] phy: qcom-ufs: fix build error when the driver is built as a module Yaniv Gardi
2015-05-20 8:14 ` Paul Bolle
2015-05-20 9:40 ` ygardi
2015-05-19 13:47 ` [PATCH v1 2/3] scsi: ufs-qcom: fix compilation warning if compiled " Yaniv Gardi
2015-05-20 8:29 ` Paul Bolle
2015-05-20 13:49 ` ygardi [this message]
2015-05-19 13:47 ` [PATCH v1 3/3] scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component Yaniv Gardi
2015-05-20 7:21 ` Paul Bolle
2015-05-20 8:22 ` Paul Bolle
2015-05-21 7:16 ` Paul Bolle
2015-05-21 10:09 ` ygardi
2015-05-21 10:14 ` Paul Bolle
2015-05-21 17:18 ` ygardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77d452918f9dad547ddf728022f82fb0.squirrel@www.codeaurora.org \
--to=ygardi@codeaurora.org \
--cc=dovl@codeaurora.org \
--cc=gbroner@codeaurora.org \
--cc=james.bottomley@hansenpartnership.com \
--cc=jbottomley@odin.com \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi-owner@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=santoshsy@gmail.com \
--cc=subhashj@codeaurora.org \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox