Re: [PATCH v3 01/48] scsi: ips: Remove an unreachable statement

Himanshu Madhani
2022-02-14T22:02:37Z

> On Feb 11, 2022, at 2:32 PM, Bart Van Assche <bvanassche@acm.org> wrote:
>
> Whether or not CONFIG_BUG is enabled, BUG() never returns. Hence, code past
> a BUG() statement is unreachable. Remove one such unreachable statement.
>
> Cc: Hannes Reinecke <hare@suse.com>
> Cc: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> Cc: John Garry <john.garry@huawei.com>
> Cc: Himanshu Madhani <himanshu.madhani@oracle.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/scsi/ips.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/ips.c b/drivers/scsi/ips.c
> index 498bf04499ce..0db35e97ce8f 100644
> --- a/drivers/scsi/ips.c
> +++ b/drivers/scsi/ips.c
> @@ -655,7 +655,6 @@ ips_release(struct Scsi_Host *sh)
> printk(KERN_WARNING
> "(%s) release, invalid Scsi_Host pointer.\n", ips_name);
> BUG();
> - return (FALSE);
> }
>
> ha = IPS_HA(sh);

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani Oracle Linux Engineering