Re: [PATCH v3 09/48] scsi: NCR5380: Move the SCSI pointer to private command data

Hannes Reinecke
2022-02-14T10:02:11Z

On 2/11/22 23:32, Bart Van Assche wrote:
> Move the SCSI pointer into the NCR5380 private command data instead of
> using the SCSI pointer from struct scsi_cmnd. This patch prepares for
> removal of the SCSI pointer from struct scsi_cmnd. The NCR5380 drivers
> have been identified as follows:
> $ git grep -l '#include.*NCR5380.h'
> drivers/scsi/arm/cumana_1.c
> drivers/scsi/arm/oak.c
> drivers/scsi/atari_scsi.c
> drivers/scsi/dmx3191d.c
> drivers/scsi/g_NCR5380.c
> drivers/scsi/mac_scsi.c
> drivers/scsi/sun3_scsi.c
>
> Cc: Finn Thain <fthain@telegraphics.com.au>
> Cc: Hannes Reinecke <hare@suse.com>
> Cc: Ondrej Zary <linux@rainbow-software.org>
> Cc: Michael Schmitz <schmitzmic@gmail.com>
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/scsi/NCR5380.c | 89 ++++++++++++++++++++++++---------------
> drivers/scsi/NCR5380.h | 1 +
> drivers/scsi/atari_scsi.c | 7 ++-
> drivers/scsi/g_NCR5380.c | 6 ++-
> drivers/scsi/mac_scsi.c | 7 ++-
> drivers/scsi/sun3_scsi.c | 4 +-
> 6 files changed, 72 insertions(+), 42 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer