Re: [PATCH v3 02/48] scsi: ips: Change the return type of ips_release() into 'void'

Bart Van Assche
2022-02-15T01:33:39Z

On 2/14/22 01:43, Hannes Reinecke wrote:
> On 2/11/22 23:32, Bart Van Assche wrote:
>> ips_release() has one caller and that caller ignores the value
>> returned by
>> ips_release(). Hence change the return type of that function into 'void'.
>>
>> Cc: Hannes Reinecke <hare@suse.com>
>> Cc: Johannes Thumshirn <johannes.thumshirn@wdc.com>
>> Cc: John Garry <john.garry@huawei.com>
>> Cc: Himanshu Madhani <himanshu.madhani@oracle.com>
>> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
>> ---
>>   drivers/scsi/ips.c | 7 ++-----
>>   1 file changed, 2 insertions(+), 5 deletions(-)
>>
> Nit: could be merged with the previous patch.
> But nothing critical, and can be done in the next version (if such a
> thing is necessary).

Hmm ... isn't the rule one change per patch? Anyway, I can combine the
first two patches if you feel strongly about this.

Thanks,

Bart.