Re: [PATCH v3 06/48] scsi: Remove drivers/scsi/scsi.h

Hannes Reinecke
2022-02-14T09:56:59Z

On 2/11/22 23:32, Bart Van Assche wrote:
> The following two header files have the same file name: include/scsi/scsi.h
> and drivers/scsi/scsi.h. This is confusing. Remove the latter since the
> following note was added in drivers/scsi/scsi.h in 2004:
>
> "NOTE: this file only contains compatibility glue for old drivers. All
> these wrappers will be removed sooner or later. For new code please use
> the interfaces declared in the headers in include/scsi/"
>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Ming Lei <ming.lei@redhat.com>
> Cc: Hannes Reinecke <hare@suse.com>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/scsi/a2091.c | 6 +++-
> drivers/scsi/a3000.c | 6 +++-
> drivers/scsi/aha152x.c | 9 ++++--
> drivers/scsi/aha1740.c | 6 +++-
> drivers/scsi/arm/acornscsi.c | 6 +++-
> drivers/scsi/arm/arxescsi.c | 6 +++-
> drivers/scsi/arm/cumana_2.c | 6 +++-
> drivers/scsi/arm/eesox.c | 6 +++-
> drivers/scsi/arm/fas216.c | 6 +++-
> drivers/scsi/arm/powertec.c | 6 +++-
> drivers/scsi/arm/queue.c | 6 +++-
> drivers/scsi/gvp11.c | 6 +++-
> drivers/scsi/ips.c | 8 ++++--
> drivers/scsi/megaraid.c | 8 ++++--
> drivers/scsi/mvme147.c | 6 +++-
> drivers/scsi/pcmcia/aha152x_stub.c | 9 ++++--
> drivers/scsi/pcmcia/nsp_cs.c | 5 ++--
> drivers/scsi/pcmcia/qlogic_stub.c | 9 ++++--
> drivers/scsi/qlogicfas.c | 6 +++-
> drivers/scsi/qlogicfas408.c | 6 +++-
> drivers/scsi/scsi.h | 46 ------------------------------
> drivers/scsi/sg.c | 8 ++++--
> drivers/scsi/sgiwd93.c | 6 +++-
> drivers/usb/image/microtek.c | 8 ++++--
> drivers/usb/storage/debug.c | 1 -
> 25 files changed, 119 insertions(+), 82 deletions(-)
> delete mode 100644 drivers/scsi/scsi.h
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer