Re: [PATCH 3/4] scsi: core: Remove procfs support

[Douglas Gilbert <dgilbert@interlog.com>]

On 2022-08-12 16:45, Bart Van Assche wrote:
> There are equivalents for all /proc/scsi functionality in sysfs. The most
> prominent user of /proc/scsi is the sg3_utils software package. Support
> for systems without /proc/scsi was added to sg3_utils in 2008. Hence
> remove procfs support from the SCSI core.

Perhaps it is just me but I find 'cat /proc/scsi/sg/debug' very useful
when something goes wrong with the sg driver or something that it depends
on. Part of my sg driver rewrite (3 years and still pending) was to
transfer the output that formerly went to /proc/scsi/sg/debug to
debugfs instead (or as well).

The most recent version of that procfs-->debugfs work for the sg driver
can be found in a post to this list titled: "[PATCH v24 35/46] sg: first
debugfs support" on 20220410.

Put another way, there are many hours of debugging experience that will be
lost by:
   drivers/scsi/sg.c           | 358 ---------------------------

Doug Gilbert


> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Ming Lei <ming.lei@redhat.com>
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: John Garry <john.garry@huawei.com>
> Cc: Mike Christie <michael.christie@oracle.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
>   drivers/scsi/Kconfig        |  11 -
>   drivers/scsi/Makefile       |   1 -
>   drivers/scsi/hosts.c        |   5 -
>   drivers/scsi/scsi.c         |   8 +-
>   drivers/scsi/scsi_devinfo.c | 146 -----------
>   drivers/scsi/scsi_priv.h    |  17 --
>   drivers/scsi/scsi_proc.c    | 477 ------------------------------------
>   drivers/scsi/sg.c           | 358 ---------------------------
>   include/scsi/scsi_host.h    |   6 -
>   9 files changed, 1 insertion(+), 1028 deletions(-)
>   delete mode 100644 drivers/scsi/scsi_proc.c
> 
<snip>