Re: [RFC PATCH] scsi: core: Drop Scsi_Host.default_lock

[John Garry <john.g.garry@oracle.com>]

On 04/08/2026 18:53, Bart Van Assche wrote:
> On 8/4/26 4:34 AM, John Garry wrote:
>> Getting the address of embedded host_lock structure just requires adding
>> a fixed offset value to the shost pointer. However, getting the value of
>> the host_lock pointer requires loading from a fixed offset to the shost
>> pointer. The latter should be very slightly slower, which is relevant as
>> this lock is used a lot throughout the core code and drivers.
> 
> I like the idea behind this patch. However, I think this patch is
> incomplete.

For sure, it's a bit of work to cover them all.

> The changes shown below are needed to make all SCSI drivers
> build again with the script available at
> https://urldefense.com/v3/__https://github.com/bvanassche/build-scsi-
> drivers__;!!ACWV5N9M2RV99hQ!
> M6E9mlAub1UcWra37zJgh_viQQpt0iL5URAr5QPhRm9PfF4eaqXeGyG1MOWRzdyojhZ3zFekfZ53Dro49iIFtQ$<https://urldefense.com/v3/__https://github.com/bvanassche/build-scsi- 
> drivers__;!!ACWV5N9M2RV99hQ! 
> M6E9mlAub1UcWra37zJgh_viQQpt0iL5URAr5QPhRm9PfF4eaqXeGyG1MOWRzdyojhZ3zFekfZ53Dro49iIFtQ$>:

Cool, I'll go through this. But how does it handle the arm v3-related 
drivers, like fas216? At a glance, the script requires 
gnu-a/10.3-2021.07/binrel/gcc-arm-10.3-2021.07 - but I thought that HW 
like this requires an even earlier toolchain version.

> 
> diff --git a/drivers/s390/scsi/zfcp_sysfs.c b/drivers/s390/scsi/zfcp_sysfs.c
> index 4f23d585d062..b1ed0cb30a72 100644
> --- a/drivers/s390/scsi/zfcp_sysfs.c
> +++ b/drivers/s390/scsi/zfcp_sysfs.c

Thanks!