Re: [PATCH v5 01/40] scsi: define all additional sense codes and their qualifiers

[Bart Van Assche <bvanassche@acm.org>]

On 9/7/26 5:30 PM, Damien Le Moal wrote:
> Sure, easy to do. But I have not seen any compilation errors. So their is
> currently no clash, but indeed, this is at the mercy of any change in included
> files. So better safe here and I will rename. Not sure what a good prefix is
> though... Maybe SCSI_WARNING ? Or SCSI_SENSE_WARNING ? Any better suggestion?

As you know any enumeration label ends up in the global namespace so
it's considered a good practice to make the names of all enumeration
labels of the same enumeration type start with the same prefix. Would
it be acceptable to make all labels in enum scsi_sense_code start with
the SCSI_SENSE_ prefix? The labels in enum scsi_sense_key probably could
also use a prefix? Constants with names like "NOT_READY" and "COMPLETED"
might also be defined in other kernel headers. Would SSK_ (SCSI SENSE
KEY) be a good prefix?

Thanks,

Bart.