From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84287171CD for ; Sat, 14 Mar 2026 07:21:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773472896; cv=none; b=YAgIEh98OqwC6iqjVJ+RHX5wDC3VAFu3iA7gnyo6Sga58JH47BH9h/tfzUMypbymKfDukatyieSq+0jMDZVjinKtkJFq2qQLDqgPePKus8VZVUOw5miOd0yRHi+rlZJScqyEjFffx33clca5bmKZ22FlrQuicc7bzktz0KhQsUg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773472896; c=relaxed/simple; bh=n3gQPsBYj95+UFJRlTWdyN6szSVhNHeFCq3ECtPYD44=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Hw9qlULQlDIwfTB8k0BoHJbHD4WymuDLWGYx+OIlWf2s/FwbCbXyEvEFebAo8gwXhdenuHGOck+E0wYfvR630QL4h8Y98VN1kDW8jsf9t3/1jwxj4MqYHsqPjn4VLkYKPYwu8erwlDfN1+1v7fLlJKtyxlzS9UGQmY/Dm9ArGHU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pjQdafnH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JC+C+w3I; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pjQdafnH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JC+C+w3I" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62E5RnBq2997621 for ; Sat, 14 Mar 2026 07:21:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QU2LBcgAvCPPWBcn4VVnnvgq9slBddM7xfCczZ90R/I=; b=pjQdafnHGkZ+aKVc NdCKU6UoGRmo30NPqRauAzKQypsIDLgBGDrHWssiH8b1R80YvABqEinbEMBBWawZ jgAgkvb08v1XTTFuxikbLKktTL4frjF9Oi1T8J6VMi45tWN1Qlwv/4ZMLhhnI4sW hiUm5XfFAFqcnQX644xm8YJUkEZlGHsTL1EnhCdv/VJcpzhMJBHwXELJaGFXRgmS NM1X/wRj7GV35pfkp7Z7h6Zm0UxN9pJIzWil79wK9sPh+2XUM3JqG1/bf5Q0bcmP Bpn70+1aSiCG2JlNTR2u44goUcEBhsqvekqI2iwkW8bB9BGACdBvZLSkPvPVDzB9 99DW8g== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cvyy5gaxc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 14 Mar 2026 07:21:34 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2ae47b3adacso30249675ad.3 for ; Sat, 14 Mar 2026 00:21:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773472894; x=1774077694; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QU2LBcgAvCPPWBcn4VVnnvgq9slBddM7xfCczZ90R/I=; b=JC+C+w3Il99qRcwWLupaiwONE7dmAOroQAqCmZyCAsBDpn6Og8nAkf0quVvqSim6g0 GPkVkZAcXbDnM5hInNz1p4dw+ddKXTmc6lKZm8rruGyx1EJDH19Ferne4FCZHcqhJ7xR SzHCozyZ0WQBdXgcOud+jOY6LIgSASHQlZonWc5OIGlhdTn6LDrvqbe9scFIBVJYcH5/ Es2Yu2/RHnmLpvtC1Ys5V2Jqs0RPG+o9yYdypEybyqUT4STMdvm7O/I43CvsCEW+KvWT tj6WMkoLo//Ved3sKE/xUecDR7sShDUz7xNRq+KIwdtMnK4yAiHewSsNfK1pPTwGo2Wx G4Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773472894; x=1774077694; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QU2LBcgAvCPPWBcn4VVnnvgq9slBddM7xfCczZ90R/I=; b=qSu6060l9qnjkcYNcnjjEHz2ptV8kEyQb6PFntV/9/CggvMHyOfbMbkyDn2HMPJZt3 E5fkpXLxnk+nUIiTPXSpkMFnHyRfnNKLAw7OXW1Ln+tJYvT0BRbLFIX29LRyBagzULmK Gq4f//+dcuoI2BCAeUvFW6ncTSX8/hOhub1gtR2jOy9rM33gVDH0oWg7KX66E/52bKzB 49gm/Ld9PdO8BbIyVs7neRJH5XfsgNlIEnrEKNpEhyQyHunFcN0FSYO/nHrtY4JMfF8V //ffY+1VOSui4yznpO1pQRbUqzt7Gejtac2DeAPtsbLICTQMPGw57OjwW058/n6uuCAb bQMA== X-Gm-Message-State: AOJu0YzEbvvxT+F7iSKrTz/vYwd9JILqY294R0RSrPQ3fjj88UPm/iWK j6S/9FTJqHlgF+pnc9Ba07+7cCguBTB19Ye341EVzRSWmNIx24DBaVupnLXoggCQqsuNcbP/Cur /3Qkkys2j5C91PY13ZpW4Ubajy7x2fzDuDgIakHjD+3ogF6mhMLixLm5GYz1Jglrt X-Gm-Gg: ATEYQzz46DMnixhOZRg8D53TMaypx0r14Guk/ecBwpnhswT0CH/V2JgNo3GVjNgsOdg DYjX4waq0lSMB1tnHKcoT9g/RiD58Ce4McqgRtPdDFL8nVKFPLNSSgjOoX7Xn5J3r2d/oppuCFL 6dUuyVJ3MSKljNUirQoIOLSK8liDyEQqh1rZeSTuFQr/8fgPKAGGArH3TFY80cG9iAAW3CQYWmJ 9neq7QAQG+1URrhO/f2hG2QZ2JPFPUxk45J3uCGjJcb88+/jF8rNVv6uqX0JLeyWKLqbZT2Nkvn YUf8Wl7+n0dqOTF2UOFYwyC+OtpDM6nWhiKmpHpKeU6YBQBpW50TR899mxMsOKiFnvDNYZ85m49 RBvuQbrrdk/9zGc4b1btEtf8ftd5g5jhhQZLeBm0n2loZV6a2PbbyeU5IBmiobigwtw9bqe2hkE cz49iBtvvfmw== X-Received: by 2002:a17:903:2b03:b0:2ae:557e:1f75 with SMTP id d9443c01a7336-2aecab07540mr57767835ad.29.1773472894141; Sat, 14 Mar 2026 00:21:34 -0700 (PDT) X-Received: by 2002:a17:903:2b03:b0:2ae:557e:1f75 with SMTP id d9443c01a7336-2aecab07540mr57767635ad.29.1773472893643; Sat, 14 Mar 2026 00:21:33 -0700 (PDT) Received: from [10.133.33.24] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece8453cdsm41005825ad.84.2026.03.14.00.21.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Mar 2026 00:21:33 -0700 (PDT) Message-ID: <7b40df1f-1c53-47e9-99bb-13d6d030eeaf@oss.qualcomm.com> Date: Sat, 14 Mar 2026 15:21:23 +0800 Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 01/12] scsi: ufs: core: Introduce a new ufshcd vops negotiate_pwr_mode() To: Bart Van Assche , avri.altman@wdc.com, beanhuo@micron.com, martin.petersen@oracle.com, mani@kernel.org Cc: linux-scsi@vger.kernel.org, Alim Akhtar , "James E.J. Bottomley" , Sai Krishna Potthuri , Ajay Neeli , Peter Griffin , Krzysztof Kozlowski , Peter Wang , Chaotian Jing , Stanley Jhu , Orson Zhai , Baolin Wang , Chunyan Zhang , Matthias Brugger , AngeloGioacchino Del Regno , "Bao D. Nguyen" , Adrian Hunter , Archana Patni , open list , "open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER..." , "moderated list:ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES" , "moderated list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER..." , "open list:ARM/QUALCOMM MAILING LIST" References: <20260308151409.3779137-1-can.guo@oss.qualcomm.com> <20260308151409.3779137-2-can.guo@oss.qualcomm.com> Content-Language: en-US From: Can Guo In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: 3DvtG0lS63a69xuFtaS67X56Fv-SlyN7 X-Authority-Analysis: v=2.4 cv=QOxlhwLL c=1 sm=1 tr=0 ts=69b50c7e cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=CqDDh8lFt03Jwv5G6gcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: 3DvtG0lS63a69xuFtaS67X56Fv-SlyN7 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE0MDA1NSBTYWx0ZWRfXx+jy5y3eMjHP cQ9F7Rv72/fJv7EwjpevMSRse2TQPHNkAZIIALFXTnRFakSsjG+Jzu8ME4hgX1GZPDx+T2RGQMH 46xCCYxnSt0p+7hBE5GqdpE5fhSlbaDaw1vlOBaoCA6WNreEQfI2zFiLD0mZ4Fi6YrtWV3mZplo HQDTeaRO/wjM7POxSCGjdrDTiPCaLgBz0tfjrcVJv8NIU0as2JXc/LOU1JhSxlGBoSNm/WDSIQF l7FU3rQmjMig3TY21rqMQbagAPTlZxzv/p6anadWIjGT/BNjqHtjfyafXu/8mebM/2RnO0YMjX8 CUaC2OXScJiFLwUHGycbXjXABZH2Rl6mPfpm6JxxgE47Qd30+m/8N1/jDXepETFB1jyTJ24tXeC roLI5pL7jdropL3geLOuNOJ+AOW8em6Y92IV7wHuqxr+XKllpeNYKe4/h63NErYDhqS+lY9S88H SK7lIE9f759XGDjwaug== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-14_02,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1015 adultscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603140055 Hi Bart, On 3/14/2026 6:09 AM, Bart Van Assche wrote: > On 3/8/26 8:13 AM, Can Guo wrote: >> +static int exynos_ufs_negotiate_pwr_mode(struct ufs_hba *hba, >> +                     const struct ufs_pa_layer_attr *dev_max_params, >> +                     struct ufs_pa_layer_attr *dev_req_params) >> +{ >> +    struct ufs_host_params host_params; >> +    int ret; >> + >> +    if (!dev_req_params) { >> +        pr_err("%s: incoming dev_req_params is NULL\n", __func__); >> +        return -EINVAL; >> +    } >> + >> +    ufshcd_init_host_params(&host_params); >> + >> +    /* This driver only support symmetric gear setting e.g. >> hs_tx_gear == hs_rx_gear */ >> +    host_params.hs_tx_gear = exynos_ufs_get_hs_gear(hba); >> +    host_params.hs_rx_gear = exynos_ufs_get_hs_gear(hba); >> + >> +    ret = ufshcd_negotiate_pwr_params(&host_params, dev_max_params, >> dev_req_params); >> +    if (ret) >> +        pr_err("%s: failed to determine capabilities\n", __func__); >> + >> +    return ret; >> +} > > The dev_req_params test is not necessary since the UFS core never > passes a NULL pointer as third argument, isn't it? I propose to remove > the > dev_req_params test. I considered the same when I made the change but I didn't do so because I wanted to keep the original codes as same as possible in vendor specific implementations... I will remove the check in next version and see if their maintainers are OK with that or not. > >> +static int ufs_hisi_negotiate_pwr_mode(struct ufs_hba *hba, >> +                       const struct ufs_pa_layer_attr *dev_max_params, >> +                       struct ufs_pa_layer_attr *dev_req_params) >> +{ >> +    struct ufs_host_params host_params; >> +    int ret; >> + >> +    if (!dev_req_params) { >> +        dev_err(hba->dev, "%s: incoming dev_req_params is NULL\n", >> __func__); >> +        return -EINVAL; >> +    } >> + >> +    ufs_hisi_set_dev_cap(&host_params); >> +    ret = ufshcd_negotiate_pwr_params(&host_params, dev_max_params, >> dev_req_params); >> +    if (ret) >> +        dev_err(hba->dev, "%s: failed to determine capabilities\n", >> __func__); >> + >> +    return ret; >> +} > > Same comment here - please remove the dev_req_params test. Will do. > >> +static int ufs_qcom_negotiate_pwr_mode(struct ufs_hba *hba, >> +                       const struct ufs_pa_layer_attr *dev_max_params, >> +                       struct ufs_pa_layer_attr *dev_req_params) >>   { >>       struct ufs_qcom_host *host = ufshcd_get_variant(hba); >>       struct ufs_host_params *host_params = &host->host_params; >> +    int ret; >> + >> +    if (!dev_req_params) { >> +        pr_err("%s: incoming dev_req_params is NULL\n", __func__); >> +        return -EINVAL; >> +    } >> + >> +    ret = ufshcd_negotiate_pwr_params(host_params, dev_max_params, >> dev_req_params); >> +    if (ret) >> +        dev_err(hba->dev, "%s: failed to determine capabilities\n", >> __func__); >> + >> +    return ret; >> +} > > Also here, please remove the dev_req_params test. Sure. > > Additionally, I see that identical "if (ret) dev_err(...)" code occurs > in the three callbacks shown above. Shouldn't that code be moved into > the only caller of these functions in the UFS core? Point taken. Thanks, Can Guo. > > Thanks, > > Bart.