From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Sathya Prakash <sathya.prakash@broadcom.com>,
Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
"MPT-FusionLinux . pdl" <MPT-FusionLinux.pdl@broadcom.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] scsi: mptfusion: Clear the warnings indicating that the variable is not used
Date: Tue, 13 Apr 2021 15:25:56 +0800 [thread overview]
Message-ID: <7b538451-4e1e-4f4b-36e5-ad496ab40598@huawei.com> (raw)
In-Reply-To: <yq1blai7p1z.fsf@ca-mkp.ca.oracle.com>
On 2021/4/13 13:07, Martin K. Petersen wrote:
>
> Zhen,
>
>> Zhen Lei (3):
>> scsi: mptfusion: Remove unused local variable 'time_count'
>> scsi: mptfusion: Remove unused local variable 'port'
>> scsi: mptfusion: Fix error return code of mptctl_hp_hostinfo()
>
> I applied patches 1+2. I hesitate making functional changes to such an
> old driver.
I think patch 3 does not change any functions. The current modification only
ensures that error codes are correctly returned in the error branch. In the
previous version, 0 is always returned.
>
next prev parent reply other threads:[~2021-04-13 7:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 6:18 [PATCH 0/3] scsi: mptfusion: Clear the warnings indicating that the variable is not used Zhen Lei
2021-04-08 6:18 ` [PATCH 1/3] scsi: mptfusion: Remove unused local variable 'time_count' Zhen Lei
2021-04-08 6:18 ` [PATCH 2/3] scsi: mptfusion: Remove unused local variable 'port' Zhen Lei
2021-04-08 6:18 ` [PATCH 3/3] scsi: mptfusion: Fix error return code of mptctl_hp_hostinfo() Zhen Lei
2021-04-13 5:07 ` [PATCH 0/3] scsi: mptfusion: Clear the warnings indicating that the variable is not used Martin K. Petersen
2021-04-13 7:25 ` Leizhen (ThunderTown) [this message]
2021-04-16 2:51 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b538451-4e1e-4f4b-36e5-ad496ab40598@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sathya.prakash@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox