From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53CF71E411D; Tue, 7 Jan 2025 10:05:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736244325; cv=none; b=u62kYkDvNkbtb2TlgaRF8z1KMY70cDoYTuZ19BZefWZ/wHddEBV1y5y+j6TU8c38n8qnEDnqIDZqDL05fH1jn1E4OG63Kgq8qMaeeX8tl9/5sbG7vYVhnzFuytD/zX84uhgcwulLgnHoVoIO7x9CPK7jHihtXa/Ad4ocKERisv0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736244325; c=relaxed/simple; bh=8jmwATyEWLLwjfjL024kECAWxrvcDtaSF8/ccLUrRk0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oo6ywnCWPvVbpTmZZJJKDIS7xIrDyaJelXEmaQHyMMLtvNQpX4bOI6mCE2tlJoC7t7e0doGP7P2Tb+NaKhVK53CYaY4dlZx/l5x0hpLR1wu7NJoFzuTGC+ajHTwxNDAwu7o96MH5BGfLE8vXWK+iYxSnHhqRVIejB4PAOpzCyoo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DIw6BHFN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DIw6BHFN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40471C4CED6; Tue, 7 Jan 2025 10:05:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736244324; bh=8jmwATyEWLLwjfjL024kECAWxrvcDtaSF8/ccLUrRk0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=DIw6BHFNgyqts2cNELuVQttSkjcAkkJIgJaA61FIsDemIS6AdCijrFRkuBPWpkx/5 XhXPZPpKu4jNf8F3ktCmp532okyjwpacmYaujmIEIY7tqvPxSC/vUkU4mTqPgh11vZ qEBLJ/dv9nxgfP2LKKinCS4zWPgSbTg0EANUofB5h4Wvr0qgnsPDb4Jm2LPBcV4TUX dY4kkhRg6Z+OD+L17EVG5TMpLu58NApwtG91MsrzYJqtyVsnXh6ktikKwLYqjhS23H 1+ZkCaZ5vF1vnzJjKeXGEzZilHvOO9Ne+HWM2IDakE0CLmCE3ostPXxHmkaYuoQr7k 1ewQaWGyDJo8Q== Message-ID: <7b657b32-dd25-4826-9c2f-dfd980610de2@kernel.org> Date: Tue, 7 Jan 2025 19:05:22 +0900 Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/8] block: add a store_limit operations for sysfs entries To: Christoph Hellwig , Jens Axboe Cc: Ming Lei , Nilay Shroff , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, nbd@other.debian.org, linux-scsi@vger.kernel.org, usb-storage@lists.one-eyed-alien.net References: <20250107063120.1011593-1-hch@lst.de> <20250107063120.1011593-5-hch@lst.de> From: Damien Le Moal Content-Language: en-US Organization: Western Digital Research In-Reply-To: <20250107063120.1011593-5-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/7/25 15:30, Christoph Hellwig wrote: > De-duplicate the code for updating queue limits by adding a store_limit > method that allows having common code handle the actual queue limits > update. > > Note that this is a pure refactoring patch and does not address the > existing freeze vs limits lock order problem in the refactored code, > which will be addressed next. > > Signed-off-by: Christoph Hellwig Looks good. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research