From: Nihar Ranjan Panda <niharp@linux.ibm.com>
To: sashiko-reviews@lists.linux.dev
Cc: Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
linux-scsi@vger.kernel.org, linux-s390@vger.kernel.org,
Alexander Gordeev <agordeev@linux.ibm.com>
Subject: Re: [PATCH 1/1] fix memory leak during adapter release by destroying gid_pn_req
Date: Mon, 20 Jul 2026 13:25:31 +0530 [thread overview]
Message-ID: <7c25d2af-d224-4d23-98ba-e2e89f7bdf95@linux.ibm.com> (raw)
In-Reply-To: <20260720074027.649FD1F000E9@smtp.kernel.org>
Hi Martin and James,
The bug reported by the sashiko bot is a pre-existing issue and was not introduced by this fix.
Please allow this fix to go upstream. We will create an EWM ticket to address the bot's finding in a separate patch.
On 20/07/26 1:10 pm, sashiko-bot@kernel.org wrote:
> Pre-existing issues:
> - [High] The error path in `zfcp_adapter_enqueue()` calls `zfcp_erp_thread_kill()` which unconditionally passes `adapter->erp_thread` to `kthread_stop()`. If adapter initialization fails before the thread is created (e.g., during `zfcp_allocate_low_mem_buffers()`), this results in a kernel panic because `kthread_stop()` does not handle NULL pointers.
> --
>
> --- Patch [1]: [PATCH 1/1] fix memory leak during adapter release by destroying gid_pn_req ---
> commit 5b4668bd066d14a43f77f6f0301f8c98cbb5069c
> Author: Benjamin Block <bblock@linux.ibm.com>
>
> fix memory leak during adapter release by destroying gid_pn_req
prev parent reply other threads:[~2026-07-20 7:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 7:27 [PATCH 0/1] zfcp bugfix for 7.2 Nihar Panda
2026-07-20 7:27 ` [PATCH 1/1] fix memory leak during adapter release by destroying gid_pn_req Nihar Panda
2026-07-20 7:40 ` sashiko-bot
2026-07-20 7:55 ` Nihar Ranjan Panda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c25d2af-d224-4d23-98ba-e2e89f7bdf95@linux.ibm.com \
--to=niharp@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox