From: Xose Vazquez Perez <xose.vazquez@gmail.com>
To: DM_DEVEL-ML <dm-devel@lists.linux.dev>
Cc: Wayne Berthiaume <Wayne.Berthiaume@dell.com>,
Vasuki Manikarnike <vasuki.manikarnike@hpe.com>,
Martin George <marting@netapp.com>,
NetApp RDAC team <ng-eseries-upstream-maintainers@netapp.com>,
Zou Ming <zouming.zouming@huawei.com>,
Li Xiaokeng <lixiaokeng@huawei.com>,
Randy Jennings <randyj@purestorage.com>,
Thomas Song <tsong@purestorage.com>,
Jyoti Rani <jrani@purestorage.com>,
Brian Bunker <brian@purestorage.com>,
Uday Shankar <ushankar@purestorage.com>,
Chaitanya Kulkarni <kch@nvidia.com>,
Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
Christoph Hellwig <hch@lst.de>,
Marco Patalano <mpatalan@redhat.com>,
"Ewan D. Milne" <emilne@redhat.com>,
John Meneghini <jmeneghi@redhat.com>,
Simon Schricker <sschricker@suse.de>,
Daniel Wagner <dwagner@suse.de>, Daniel Wagner <wagi@monom.org>,
Hannes Reinecke <hare@suse.de>, Martin Wilck <mwilck@suse.com>,
Benjamin Marzinski <bmarzins@redhat.com>,
NVME-ML <linux-nvme@lists.infradead.org>,
SCSI-ML <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] nvme-cli: nvmf-autoconnect: udev-rule: add a file for new arrays
Date: Sat, 16 Aug 2025 19:15:50 +0200 [thread overview]
Message-ID: <7ccfba05-ec5a-4a42-a1ea-5254e7b7d97f@gmail.com> (raw)
In-Reply-To: <20250815202133.51160-1-xose.vazquez@gmail.com>
On 8/15/25 10:21 PM, Xose Vazquez Perez wrote:
> And it is unnecessary to set ctrl_loss_tmo to -1 for NVMe/TCP devices,
> because it is the default.
Totally wrong. I misread the code:
$ grep NVMF_DEF_CTRL_LOSS_TMO drivers/nvme/host/fabrics.c
int ctrl_loss_tmo = NVMF_DEF_CTRL_LOSS_TMO, key_id;
$ grep ^#define drivers/nvme/host/fabrics.h
#define _NVME_FABRICS_H 1
#define NVMF_MIN_QUEUE_SIZE 16
#define NVMF_MAX_QUEUE_SIZE 1024
#define NVMF_DEF_QUEUE_SIZE 128
#define NVMF_DEF_RECONNECT_DELAY 10
#define NVMF_DEF_CTRL_LOSS_TMO 600 <---
#define NVMF_DEF_FAIL_FAST_TMO -1
It's 10 minutes.
prev parent reply other threads:[~2025-08-16 17:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 20:21 [PATCH] nvme-cli: nvmf-autoconnect: udev-rule: add a file for new arrays Xose Vazquez Perez
2025-08-16 17:15 ` Xose Vazquez Perez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ccfba05-ec5a-4a42-a1ea-5254e7b7d97f@gmail.com \
--to=xose.vazquez@gmail.com \
--cc=Wayne.Berthiaume@dell.com \
--cc=bmarzins@redhat.com \
--cc=brian@purestorage.com \
--cc=dm-devel@lists.linux.dev \
--cc=dwagner@suse.de \
--cc=emilne@redhat.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jmeneghi@redhat.com \
--cc=jrani@purestorage.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lixiaokeng@huawei.com \
--cc=marting@netapp.com \
--cc=mpatalan@redhat.com \
--cc=mwilck@suse.com \
--cc=ng-eseries-upstream-maintainers@netapp.com \
--cc=randyj@purestorage.com \
--cc=sagi@grimberg.me \
--cc=sschricker@suse.de \
--cc=tsong@purestorage.com \
--cc=ushankar@purestorage.com \
--cc=vasuki.manikarnike@hpe.com \
--cc=wagi@monom.org \
--cc=zouming.zouming@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).