public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: dgilbert@interlog.com,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
	Christoph Hellwig <hch@lst.de>,
	Daejun Park <daejun7.park@samsung.com>,
	Kanchan Joshi <joshi.k@samsung.com>
Subject: Re: [PATCH v7 00/19] Pass data lifetime information to SCSI disk devices
Date: Mon, 18 Dec 2023 15:29:01 -0800	[thread overview]
Message-ID: <7d8564bc-8711-43f5-b6b5-21ae204783f6@acm.org> (raw)
In-Reply-To: <dbfe9ac0-d432-4911-8a47-23d3d6f3811a@interlog.com>

On 12/18/23 15:08, Douglas Gilbert wrote:
> On 12/18/23 13:56, Bart Van Assche wrote:
>> Changes compared to v6:
>>   - Dropped patch "fs: Restore F_[GS]ET_FILE_RW_HINT support".
> 
> That leaves us with F_SET_RW_HINT and F_GET_RW_HINT ioctls. Could you please
> explain, perhaps with an example, what functionality is lost and what we still
> have?
Hmm ... what information do you expect that is not available in the fcntl man
page? From that man page:

        F_SET_RW_HINT (uint64_t *; since Linux 4.13)
               Sets the read/write hint value associated with the underlying inode re‐
               ferred to by fd.  This hint persists until either it is explicitly mod‐
               ified or the underlying filesystem is unmounted.

        F_SET_FILE_RW_HINT (uint64_t *; since Linux 4.13)
               Sets the read/write hint value associated with the open  file  descrip‐
               tion referred to by fd.

The functionality that is lost is to open a file multiple times and to call
F_SET_FILE_RW_HINT with a different value for each file. Ceph used this approach
to specify R/W hints per LBA range in combination with direct I/O.

Bart.

      reply	other threads:[~2023-12-18 23:29 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-18 18:56 [PATCH v7 00/19] Pass data lifetime information to SCSI disk devices Bart Van Assche
2023-12-18 18:56 ` [PATCH v7 01/19] fs: Fix rw_hint validation Bart Van Assche
2023-12-18 18:56 ` [PATCH v7 02/19] fs: Verify write lifetime constants at compile time Bart Van Assche
2023-12-18 18:56 ` [PATCH v7 03/19] fs: Split fcntl_rw_hint() Bart Van Assche
2023-12-18 18:56 ` [PATCH v7 04/19] fs: Move enum rw_hint into a new header file Bart Van Assche
2023-12-18 18:56 ` [PATCH v7 05/19] block, fs: Restore the per-bio/request data lifetime fields Bart Van Assche
2023-12-18 20:50   ` Dave Chinner
2023-12-18 18:56 ` [PATCH v7 06/19] block, fs: Propagate write hints to the block device inode Bart Van Assche
2023-12-18 18:56 ` [PATCH v7 07/19] fs/f2fs: Restore the whint_mode mount option Bart Van Assche
2023-12-18 18:56 ` [PATCH v7 08/19] fs/f2fs: Restore support for tracing data lifetimes Bart Van Assche
2023-12-18 18:56 ` [PATCH v7 09/19] scsi: core: Query the Block Limits Extension VPD page Bart Van Assche
2023-12-18 18:56 ` [PATCH v7 10/19] scsi: scsi_proto: Add structures and constants related to I/O groups and streams Bart Van Assche
2023-12-18 18:56 ` [PATCH v7 11/19] scsi: sd: Translate data lifetime information Bart Van Assche
2023-12-18 18:56 ` [PATCH v7 12/19] scsi: scsi_debug: Reduce code duplication Bart Van Assche
2023-12-18 18:56 ` [PATCH v7 13/19] scsi: scsi_debug: Support the block limits extension VPD page Bart Van Assche
2023-12-18 18:56 ` [PATCH v7 14/19] scsi: scsi_debug: Rework page code error handling Bart Van Assche
2023-12-18 18:56 ` [PATCH v7 15/19] scsi: scsi_debug: Rework subpage " Bart Van Assche
2023-12-18 18:56 ` [PATCH v7 16/19] scsi: scsi_debug: Allocate the MODE SENSE response from the heap Bart Van Assche
2023-12-18 18:56 ` [PATCH v7 17/19] scsi: scsi_debug: Implement the IO Advice Hints Grouping mode page Bart Van Assche
2023-12-18 18:56 ` [PATCH v7 18/19] scsi: scsi_debug: Implement GET STREAM STATUS Bart Van Assche
2023-12-18 18:56 ` [PATCH v7 19/19] scsi: scsi_debug: Maintain write statistics per group number Bart Van Assche
2023-12-18 23:08 ` [PATCH v7 00/19] Pass data lifetime information to SCSI disk devices Douglas Gilbert
2023-12-18 23:29   ` Bart Van Assche [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d8564bc-8711-43f5-b6b5-21ae204783f6@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=daejun7.park@samsung.com \
    --cc=dgilbert@interlog.com \
    --cc=hch@lst.de \
    --cc=joshi.k@samsung.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox