From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEF7C199954 for ; Wed, 2 Oct 2024 22:39:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727908792; cv=none; b=fzmQQSplkanOgIO3HZfd+qvHmRMrWDGp8SU7MjnLBTp0/41z1fMHiSNip/ZWOVE9hZ9p1LFC/CUbRdbYpPnLUihlhj53/PI10YSm4B8WSAoVVaQtvPRt1i58d4/R06RvUkwZzhFebTQmnZ1qpcQ5WPAWPn2bOwzm2nt4Nl2fwPc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727908792; c=relaxed/simple; bh=QZKoGZh3y6sZfJVuTzq7kxydp6cmBgglYtV1DQ4h9I8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=G9/rFzpjLJJb1Qw80mU5JlKTluFXK/mLJbTxSC+9OPwrdNBfAMqitXKzUyn/r65famNfG27hh1ZgZR3U04ImUwtauC7WlsXTIgCE6J7JeRST+oUpUWTNDPinAseSI/yX/kXQPGSRHnet5Cb9GmimQlpOpnTHh2gnb1gPO+PvPic= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aId4/bX1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aId4/bX1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4149FC4CEC5; Wed, 2 Oct 2024 22:39:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727908791; bh=QZKoGZh3y6sZfJVuTzq7kxydp6cmBgglYtV1DQ4h9I8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=aId4/bX1dtd7cHhelnuC6tW/2Rloe+UR8w1OALbkFnOFFQTJtFWvRKdsvHrpCaX3i wlVHXJzDpeyDmfbHlLg8ary9yfZjrl1L78jPcBil2quVY+sDrqZ3/Dc5QP2ZUeRUpR ecj2IQtM+0pUD8Dq5nEgyrUbfZKZNwguqnA1mOZ7JEPHGHqlSGuW4tXiIm/deFm/LL P/yKevwTyOmCXob+sI35MO9PJat1yJBM8sTRyCOci6GGj7vS2Un7tBGC4dJEijFMI9 h0lV/US1iDrG874vRQOtXZKkwmVx70LL+V1Nr2DmpF5sGn1Sob/2mwTYH2wdzxWLE/ rZAQM1nKq7W4w== Message-ID: <7f2ae124-e98c-4360-8ab8-654a197751f9@kernel.org> Date: Thu, 3 Oct 2024 07:39:43 +0900 Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 06/11] scsi: Rename .slave_alloc() and .slave_destroy() To: Bart Van Assche , "Martin K . Petersen" Cc: linux-scsi@vger.kernel.org, Niklas Cassel , Takashi Sakamoto , Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , Steffen Maier , Benjamin Block , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , "James E.J. Bottomley" , Hannes Reinecke , Anil Gurumurthy , Sudarsana Kalluru , Saurav Kashyap , Javed Hasan , GR-QLogic-Storage-Upstream@marvell.com, Oliver Neukum , Ali Akcaagac , Jamie Lenehan , Satish Kharat , Sesidhar Baddela , Karan Tilak Kumar , Yihang Li , Don Brace , Tyrel Datwyler , Michael Ellerman , Brian King , James Smart , Dick Kennedy , Kashyap Desai , Sumit Saxena , Shivasharan S , Chandrakanth patil , Nilesh Javali , Manish Rangankar , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Matthew Wilcox , "Michael S. Tsirkin" , Jason Wang , Juergen Gross , Stefano Stabellini , Greg Kroah-Hartman , Alan Stern , Geoff Levand , Khalid Aziz , John Garry , Soumya Negi , Peter Wang , Manivannan Sadhasivam , Avri Altman , Andrew Halaney , Bean Huo , "Bao D. Nguyen" References: <20241002203528.4104996-1-bvanassche@acm.org> <20241002203528.4104996-7-bvanassche@acm.org> From: Damien Le Moal Content-Language: en-US Organization: Western Digital Research In-Reply-To: <20241002203528.4104996-7-bvanassche@acm.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/3/24 05:33, Bart Van Assche wrote: > Rename .slave_alloc() into .sdev_prep() and .slave_destroy() into "sdev_init" or "sdev_initialize" may be a better name instead of "sdev_prep", which does not really convey what the call will be preparing for. Also, "prep" not being fully spelled out may confuse some people. Thoughts ? Other than that, looks good to me. -- Damien Le Moal Western Digital Research