From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jack Wang" Subject: RE: [PATCH] libsas: fix definition of wideport, include local sas address Date: Mon, 4 Oct 2010 07:47:08 +0800 Message-ID: <803C0CAF9ECC49B1B53C41064DE42DF0@usish.com.cn> References: <20101001205552.30032.87278.stgit@localhost.localdomain><35DEA0DE11CB42F8B788D1C3C4E7BBA0@usish.com.cn> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from sr-smtp.usish.com ([210.5.144.203]:46756 "EHLO sr-smtp.usish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753096Ab0JEBxl convert rfc822-to-8bit (ORCPT ); Mon, 4 Oct 2010 21:53:41 -0400 In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: 'Dan Williams' Cc: james.bottomley@suse.de, 'Jeff Skirvin' , 'Patrick Thomson' , linux-scsi@vger.kernel.org Re: [PATCH] libsas: fix definition of wideport, include local sas addre= ss On Sat, Oct 2, 2010 at 6:55 PM, Jack Wang wrote: > > To date libsas has only looked at the attached sas address when > determining the formation of wide ports. =A0The specification and som= e > hardware expects that phys with different addresses will not form a w= ide > port unless the local peer phys also match each other. =A0Introduce a= flag > to select stricter behavior at sas_register_ha() time. =A0The flag ca= n be > dropped once it is known that all libsas users expect the same behavi= or. > > Current drivers just initialize this field to zero and get the > traditional behavior. > [Jack] I prefer to use the new definition of wideport to the default. Ok, when mvsas and aic94xx are also ready for this change we can just make this the default and kill the flag. > [Jack] I cann't find where to judge the flag to chose which definitio= n to > use? I am not clear on the question. phy_is_wideport_member() should be the only location that needs to read this flag. The driver just sets it to 1 before calling sas_register_ha() and then assumes the strict definition is in effect for the lifetime of the driver instance. [Jack] Ohh, I miss something in the patch. It's ok for me. Thanks for Explanation. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html