From: Bart Van Assche <bvanassche@acm.org>
To: Hannes Reinecke <hare@suse.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] pcmcia/nsp_cs: Use SAM_STAT_CHECK_CONDITION
Date: Thu, 27 May 2021 09:43:14 -0700 [thread overview]
Message-ID: <80a68701-2fe4-e2ae-8d9f-98b0e865c670@acm.org> (raw)
In-Reply-To: <20210527072217.117126-1-hare@suse.de>
On 5/27/21 12:22 AM, Hannes Reinecke wrote:
> The nsp_cs driver stores the SAM status values in SCp.Status, so
> we need to use the non-shifted version SAM_STAT_CHECK_CONDITION.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
> drivers/scsi/pcmcia/nsp_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/pcmcia/nsp_cs.c b/drivers/scsi/pcmcia/nsp_cs.c
> index ac89002646a3..7c0f931e55e8 100644
> --- a/drivers/scsi/pcmcia/nsp_cs.c
> +++ b/drivers/scsi/pcmcia/nsp_cs.c
> @@ -221,7 +221,7 @@ static int nsp_queuecommand_lck(struct scsi_cmnd *SCpnt,
>
> data->CurrentSC = SCpnt;
>
> - SCpnt->SCp.Status = CHECK_CONDITION;
> + SCpnt->SCp.Status = SAM_STAT_CHECK_CONDITION;
> SCpnt->SCp.Message = 0;
> SCpnt->SCp.have_data_in = IO_UNKNOWN;
> SCpnt->SCp.sent_command = 0;
Since this patch is a bug fix, does this patch need a Cc: stable tag?
I'm not sure how to add a Fixes: tag since this bug predates Linux
kernel v2.6.12.
Thanks,
Bart.
prev parent reply other threads:[~2021-05-27 16:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 7:22 [PATCH] pcmcia/nsp_cs: Use SAM_STAT_CHECK_CONDITION Hannes Reinecke
2021-05-27 16:43 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80a68701-2fe4-e2ae-8d9f-98b0e865c670@acm.org \
--to=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox