From: GOTO Masanori <gotom@debian.or.jp>
To: Andi Kleen <ak@muc.de>
Cc: linux-scsi@vger.kernel.org, gotom@debian.or.jp,
yokota@netlab.is.tsukuba.ac.jp
Subject: Re: [PATCH] Mark Workbit NinjaSCSI driver non 64bit
Date: Sun, 04 Jan 2004 03:08:59 +0900 [thread overview]
Message-ID: <813cawsy4k.wl@omega.webmasters.gr.jp> (raw)
In-Reply-To: <20040101215835.GA3001@averell>
Hi Andi,
At Thu, 1 Jan 2004 22:58:35 +0100,
Andi Kleen wrote:
> Judging from the warnings it spews out on a 64bit compilation on AMD64
> it is not 64bit clean. Mark it as such in Kconfig.
>
> Better would be of course to fix it.
Thanks for your report. I compiled and exactly I saw some warnings on
amd64 machine. I checked all warnings, and these warnings are
trivial, they can be easily fixed. I attached the patch to fix
warnings. Nsp32 is PCI device driver, so it should also work on amd64
architecture.
--- drivers/scsi/nsp32.h.orig 2004-01-03 08:34:30.000000000 +0900
+++ drivers/scsi/nsp32.h 2004-01-03 08:34:48.000000000 +0900
@@ -667,10 +667,5 @@
}
#endif
-/* for Kernel 2.6 */
-#if (LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,0))
-# define __devinitdata /* */
-#endif
-
#endif /* _NSP32_H */
/* end */
--- drivers/scsi/nsp32_io.h.orig 2004-01-03 08:35:07.000000000 +0900
+++ drivers/scsi/nsp32_io.h 2004-01-03 08:41:47.000000000 +0900
@@ -173,7 +173,7 @@
/*==============================================*/
-static inline unsigned char nsp32_mmio_index_read1(unsigned int base,
+static inline unsigned char nsp32_mmio_index_read1(unsigned long base,
unsigned int reg)
{
volatile unsigned short *index_ptr, *data_ptr;
@@ -185,7 +185,7 @@
return readb(data_ptr);
}
-static inline void nsp32_mmio_index_write1(unsigned int base,
+static inline void nsp32_mmio_index_write1(unsigned long base,
unsigned int reg,
unsigned char val)
{
@@ -198,8 +198,8 @@
writeb(val, data_ptr );
}
-static inline unsigned short nsp32_mmio_index_read2(unsigned int base,
- unsigned int reg)
+static inline unsigned short nsp32_mmio_index_read2(unsigned long base,
+ unsigned int reg)
{
volatile unsigned short *index_ptr, *data_ptr;
@@ -210,7 +210,7 @@
return le16_to_cpu(readw(data_ptr));
}
-static inline void nsp32_mmio_index_write2(unsigned int base,
+static inline void nsp32_mmio_index_write2(unsigned long base,
unsigned int reg,
unsigned short val)
{
Regards,
-- gotom
>
> -Andi
>
> diff -burpN -X ../KDIFX linux-2.6.1-rc1/drivers/scsi/Kconfig linux-2.6.1-rc1-amd64/drivers/scsi/Kconfig
> --- linux-2.6.1-rc1/drivers/scsi/Kconfig 2004-01-01 06:25:23.000000000 +0100
> +++ linux-2.6.1-rc1-amd64/drivers/scsi/Kconfig 2004-01-01 06:56:50.000000000 +0100
> @@ -1388,7 +1388,7 @@ config SCSI_ULTRASTOR
>
> config SCSI_NSP32
> tristate "Workbit NinjaSCSI-32Bi/UDE support"
> - depends on PCI && SCSI
> + depends on PCI && SCSI && !64BIT
> help
> This is support for the Workbit NinjaSCSI-32Bi/UDE PCI/Cardbus
> SCSI host adapter. Please read the SCSI-HOWTO, available from
next prev parent reply other threads:[~2004-01-03 18:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-01 21:58 [PATCH] Mark Workbit NinjaSCSI driver non 64bit Andi Kleen
2004-01-03 18:08 ` GOTO Masanori [this message]
2004-01-03 23:27 ` Andi Kleen
2004-01-05 14:01 ` GOTO Masanori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=813cawsy4k.wl@omega.webmasters.gr.jp \
--to=gotom@debian.or.jp \
--cc=ak@muc.de \
--cc=linux-scsi@vger.kernel.org \
--cc=yokota@netlab.is.tsukuba.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox