Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

Bjorn Andersson
2019-02-04T20:27:04Z

On Mon 04 Feb 11:51 PST 2019, Avri Altman wrote:

>
> > This reverts commit 60f0187031c05e04cbadffb62f557d0ff3564490.
> >
> > Calling ufshcd_set_vccq_rail_unused hangs my system.
> > It seems vccq is not *not* needed.
> This patch essentially implements the UFS_DEVICE_NO_VCCQ quirk,
> Which is needed for both Samsung and Hynix devices.
> Once acked by those vendors, can be removed from the quirk list as well.
>

If a device does not need VCCQ, for some reason, then why is the VCCQ
supply specified for this device?

Disabling unused regulators is already handled by the regulator
framework, so why does the UFSHCD driver take this role as well?

Regards,
Bjorn