From: Douglas Gilbert <dgilbert@interlog.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
Viswas G <Viswas.G@microchip.com.com>
Cc: linux-scsi@vger.kernel.org,
Vasanthalakshmi.Tharmarajan@microchip.com,
Viswas.G@microchip.com, Ruksar.devadi@microchip.com,
Jinpu Wang <jinpu.wang@cloud.ionos.com>
Subject: Re: [PATCH V2 0/4] pm80xx updates.
Date: Tue, 6 Oct 2020 23:03:27 -0400 [thread overview]
Message-ID: <81c98e02-75cf-5f9d-612f-a67a374811c3@interlog.com> (raw)
In-Reply-To: <yq1r1qa7pw7.fsf@ca-mkp.ca.oracle.com>
On 2020-10-06 10:06 p.m., Martin K. Petersen wrote:
>
> Viswas,
>
>> Changes from v1:
>> - Improved commit messages.
>> - Fixed compiler warning for
>> "Increase the number of outstanding IO supported" patch
>
> Applied to 5.10/scsi-staging.
>
> In the future please run checkpatch and make sure that the commit
> messages are using imperative mood (see
> Documentation/process/submitting-patches.rst, section 2).
Get thee to a nunnery! [W. Shakespeare; translation: "fuck off"]
Now that is imperative.
As for "imperative mood", I believe there is no such thing in English
grammar. My mother taught grammar and I studied French and Latin at
school. Markus Elfring objected to my:
[PATCH] lib/scatterlist: Fix memory leak in sgl_alloc_order() ***
with the same "imperative mood" line. In English, including British
(i.e. "international") English taught in south Asia, that is the
_imperative_ . Basically if you can stick "You" in front of the
verb at the start of the sentence and the sense is the same, then
it is the imperative.
Is the "imperative mood" something in Danish or German grammar?
Doug Gilbert
*** That patch was ack-ed by Bart (the culprit) and as far as I
know hasn't gone any further. My sgl-to-sgl copy, compare
and sgl_memset await that bug being sorted.
next prev parent reply other threads:[~2020-10-07 3:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 14:50 [PATCH V2 0/4] pm80xx updates Viswas G
2020-10-05 14:50 ` [PATCH V2 1/4] pm80xx: Increase number of supported queues Viswas G
2020-10-06 6:45 ` Jinpu Wang
2020-10-05 14:50 ` [PATCH V2 2/4] pm80xx: Remove DMA memory allocation for ccb and device structures Viswas G
2020-10-05 14:50 ` [PATCH V2 3/4] pm80xx: Increase the number of outstanding IO supported to 1024 Viswas G
2020-10-06 6:45 ` Jinpu Wang
2020-10-05 14:50 ` [PATCH V2 4/4] pm80xx: Driver version update Viswas G
2020-10-07 2:06 ` [PATCH V2 0/4] pm80xx updates Martin K. Petersen
2020-10-07 3:03 ` Douglas Gilbert [this message]
2020-10-07 3:28 ` Bart Van Assche
2020-10-07 3:43 ` Martin K. Petersen
2020-10-13 22:43 ` Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2020-10-30 6:09 Viswas G
2021-09-06 17:04 [PATCH v2 " Ajish Koshy
2021-09-15 2:29 ` Martin K. Petersen
2021-09-22 4:45 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81c98e02-75cf-5f9d-612f-a67a374811c3@interlog.com \
--to=dgilbert@interlog.com \
--cc=Ruksar.devadi@microchip.com \
--cc=Vasanthalakshmi.Tharmarajan@microchip.com \
--cc=Viswas.G@microchip.com \
--cc=Viswas.G@microchip.com.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox