Re: [RFD driver-core] Lifetime problems of the current driver model

Tejun Heo
2007-04-03T03:08:40Z

Cornelia Huck wrote:
> On Mon, 2 Apr 2007 11:20:48 +0200,
> Cornelia Huck <cornelia.huck@de.ibm.com> wrote:
>
>> Cool. However, there's something fishy there (not sure whether it's in
>> your patch or a latent bug in the ccw bus code that just has been
>> uncovered):
>
> Similar bug when loading/unloading a module that creates a driver
> attribute. The winner seems to be kfree(sd->s_element) in
> release_sysfs_dirent() (in case of an attribute, it will point to the
> attribute structure, which is usually statically created)...

Thanks for finding it out. I was suspecting that last minute change.
The code should be

if (dir node)
kfree(s_element)
else if (symlink node)
do things and kfree()

Thanks.

--
tejun