From: Luben Tuikov <ltuikov@yahoo.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi@vger.kernel.org,
Tony Battersby <tonyb@cybernetics.com>
Subject: Re: [PATCH] [RFC] sd: make error handling more robust
Date: Fri, 1 Feb 2008 03:53:47 -0800 (PST) [thread overview]
Message-ID: <830195.4171.qm@web31808.mail.mud.yahoo.com> (raw)
In-Reply-To: <387599.14710.qm@web31814.mail.mud.yahoo.com>
--- On Thu, 1/31/08, Luben Tuikov <ltuikov@yahoo.com> wrote:
> Negate original:
> if (driver_byte(result) == DRIVER_SENSE ||
> (sense_valid && sense_defered))
> Inspect sense.
>
> Negate your proposed change "&&" ->
> "||":
> if (driver_byte(result) == DRIVER_SENSE &&
> (sense_valid || sense_deferred))
> Inspect sense.
Should read:
Negate original:
if (driver_byte(result) == DRIVER_SENSE ||
(sense_valid && !sense_deferred))
Inspect sense.
Negate your proposed change "&&" -> "||":
if (driver_byte(result) == DRIVER_SENSE &&
(sense_valid || !sense_deferred))
Inspect sense.
Luben
next prev parent reply other threads:[~2008-02-01 11:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-01 1:24 [PATCH] [RFC] sd: make error handling more robust Luben Tuikov
2008-02-01 11:53 ` Luben Tuikov [this message]
2008-02-01 13:44 ` Salyzyn, Mark
2008-02-01 16:15 ` Tony Battersby
2008-02-01 15:46 ` Tony Battersby
2008-02-01 16:09 ` James Bottomley
2008-02-01 20:06 ` Luben Tuikov
2008-02-01 21:02 ` Tony Battersby
2008-02-02 0:49 ` Luben Tuikov
2008-02-04 14:34 ` Tony Battersby
2008-02-04 21:02 ` Luben Tuikov
-- strict thread matches above, loose matches on Subject: below --
2008-01-31 21:31 Tony Battersby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=830195.4171.qm@web31808.mail.mud.yahoo.com \
--to=ltuikov@yahoo.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=tonyb@cybernetics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox