From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: John Garry <john.g.garry@oracle.com>,
martin.petersen@oracle.com, jejb@linux.ibm.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] scsi: core: Use SCSI_SCAN_INITIAL in do_scsi_scan_host()
Date: Mon, 21 Nov 2022 21:33:10 +0900 [thread overview]
Message-ID: <83c29cc2-9bf4-265f-4f8a-ab83d8b6271b@opensource.wdc.com> (raw)
In-Reply-To: <20221121121725.1910795-3-john.g.garry@oracle.com>
On 11/21/22 21:17, John Garry wrote:
> Instead of using hardcoded '0' as the do_scsi_scan_host() ->
> scsi_scan_host_selected() rescan arg, use proper macro SCSI_SCAN_INITIAL.
>
> Signed-off-by: John Garry <john.g.garry@oracle.com>
Looks good.
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
> drivers/scsi/scsi_scan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
> index 6cc974b382c1..920b145f80b7 100644
> --- a/drivers/scsi/scsi_scan.c
> +++ b/drivers/scsi/scsi_scan.c
> @@ -1920,7 +1920,7 @@ static void do_scsi_scan_host(struct Scsi_Host *shost)
> msleep(10);
> } else {
> scsi_scan_host_selected(shost, SCAN_WILD_CARD, SCAN_WILD_CARD,
> - SCAN_WILD_CARD, 0);
> + SCAN_WILD_CARD, SCSI_SCAN_INITIAL);
> }
> }
>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2022-11-21 12:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 12:17 [PATCH 0/2] scsi: Some minor scan improvements John Garry
2022-11-21 12:17 ` [PATCH 1/2] scsi: core: Use SCSI_SCAN_RESCAN in __scsi_add_device() John Garry
2022-11-21 14:30 ` Jason Yan
2022-11-21 12:17 ` [PATCH 2/2] scsi: core: Use SCSI_SCAN_INITIAL in do_scsi_scan_host() John Garry
2022-11-21 12:33 ` Damien Le Moal [this message]
2022-11-21 13:48 ` [External] : " John Garry
2022-11-26 0:13 ` Bart Van Assche
2022-11-21 14:31 ` Jason Yan
2022-11-26 2:39 ` [PATCH 0/2] scsi: Some minor scan improvements Martin K. Petersen
2022-12-01 3:45 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83c29cc2-9bf4-265f-4f8a-ab83d8b6271b@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=jejb@linux.ibm.com \
--cc=john.g.garry@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox