From: Douglas Gilbert <dgilbert@interlog.com>
To: Ming Lei <ming.lei@redhat.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
Christoph Hellwig <hch@lst.de>,
John Garry <john.garry@huawei.com>
Subject: Re: [PATCH V2] scsi: put hot fields of scsi_host_template into one cacheline
Date: Fri, 1 May 2020 18:27:07 -0400 [thread overview]
Message-ID: <841bd018-eff5-d242-97dd-416384eb4b08@interlog.com> (raw)
In-Reply-To: <20200422095425.319674-1-ming.lei@redhat.com>
On 2020-04-22 5:54 a.m., Ming Lei wrote:
> The following three fields of scsi_host_template are referenced in
> scsi IO submission path, so put them together into one cacheline:
>
> - cmd_size
> - queuecommand
> - commit_rqs
>
> Cc: Bart Van Assche <bvanassche@acm.org>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: John Garry <john.garry@huawei.com>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
> V2:
> - move the 3 fields at the beginning of scsi_host_template
> - comment why we do this way
>
> include/scsi/scsi_host.h | 72 ++++++++++++++++++++++------------------
> 1 file changed, 39 insertions(+), 33 deletions(-)
Hi,
I would like to test this patch. However it doesn't apply on Martin's
tree (all 3 chunks fail). Could you post a clean version?
Doug Gilbert
next prev parent reply other threads:[~2020-05-01 22:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 9:54 [PATCH V2] scsi: put hot fields of scsi_host_template into one cacheline Ming Lei
2020-04-22 10:06 ` John Garry
2020-04-22 14:36 ` Bart Van Assche
2020-04-22 14:41 ` James Bottomley
2020-04-23 1:48 ` Ming Lei
2020-04-23 6:02 ` Christoph Hellwig
2020-04-24 18:14 ` Martin K. Petersen
2020-05-01 22:27 ` Douglas Gilbert [this message]
2020-05-04 1:09 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=841bd018-eff5-d242-97dd-416384eb4b08@interlog.com \
--to=dgilbert@interlog.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=john.garry@huawei.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox