答复: [External Mail]RE: [PATCH] scsi: ufs: ufsfbo: Introduce File Based Optimization feature

[李佳铭 <lijiaming3@xiaomi.com>]

Dear Avri
Thanks for your review. I will modify it according to your suggestion.
After the modification, I will try to submit it to Mainline. Therefore,
this patch can be ignored, How do I delete it on:
https://patchwork.kernel.org/project/linux-scsi/list/ ?
Thanks

-----邮件原件-----
发件人: Avri Altman <Avri.Altman@wdc.com>
发送时间: 2022年8月25日 16:57
收件人: Jiaming Li <lijiamingsofine@gmail.com>; alim.akhtar@samsung.com; jejb@linux.ibm.com
抄送: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; 李佳铭 <lijiaming3@xiaomi.com>
主题: [External Mail]RE: [PATCH] scsi: ufs: ufsfbo: Introduce File Based Optimization feature

[外部邮件] 此邮件来源于小米公司外部，请谨慎处理。

> +
> +/* SYSFS DEFINE */
> +#define define_sysfs_ro(_name) __ATTR(_name, 0444,                     \
> +                                     ufsfbo_sysfs_show_##_name, NULL)
> +#define define_sysfs_wo(_name) __ATTR(_name, 0200,                     \
> +                                      NULL, ufsfbo_sysfs_store_##_name)
> +#define define_sysfs_rw(_name) __ATTR(_name, 0644,                     \
> +                                     ufsfbo_sysfs_show_##_name,        \
> +                                     ufsfbo_sysfs_store_##_name)
> +static struct ufsfbo_sysfs_entry ufsfbo_sysfs_entries[] = {
> +       define_sysfs_ro(fbo_rec_lrs),
> +       define_sysfs_ro(fbo_max_lrs),
> +       define_sysfs_ro(fbo_min_lrs),
> +       define_sysfs_ro(fbo_max_lrc),
> +       define_sysfs_ro(fbo_lra),
> +       define_sysfs_ro(fbo_prog_state),
> +       define_sysfs_ro(fbo_get_lr_frag_level),
> +       define_sysfs_ro(fbo_support),
> +       define_sysfs_ro(fbo_version),
> +       define_sysfs_wo(fbo_operation_control),
> +       define_sysfs_wo(fbo_send_lr_list),
> +       define_sysfs_rw(fbo_exe_threshold),
> +       define_sysfs_rw(fbo_wholefile_enable),
> +       /* debug */
> +       define_sysfs_rw(debug),
> +       /* Attribute (RAW) */
> +       define_sysfs_rw(block_suspend),
> +       define_sysfs_rw(auto_hibern8_enable),
> +       __ATTR_NULL
> +};
Lets stick to the _store / _show naming conventions - people rely on that when they are grepping the code.
Also, you need to document the ABI.

Thanks,
Avri
#/******本邮件及其附件含有小米公司的保密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制、或散发）本邮件中的信息。如果您错收了本邮件，请您立即电话或邮件通知发件人并删除本邮件！ This e-mail and its attachments contain confidential information from XIAOMI, which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!******/#