* [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer
@ 2014-02-21 1:12 Daeseok Youn
2014-03-11 17:02 ` Jayamohan Kallickal
0 siblings, 1 reply; 3+ messages in thread
From: Daeseok Youn @ 2014-02-21 1:12 UTC (permalink / raw)
To: JBottomley; +Cc: jayamohan.kallickal, linux-scsi, linux-kernel
>From b483ef302f7d77c586949ae170754d589e8a4935 Mon Sep 17 00:00:00 2001
From: Daeseok Youn <daeseok.youn@gmail.com>
Date: Fri, 21 Feb 2014 08:39:08 +0900
Subject: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer
sparse says:
drivers/scsi/be2iscsi/be_cmds.c:27:32: warning:
Using plain integer as NULL pointer
drivers/scsi/be2iscsi/be_cmds.c:28:34: warning:
Using plain integer as NULL pointer
drivers/scsi/be2iscsi/be_cmds.c:29:34: warning:
Using plain integer as NULL pointer
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
drivers/scsi/be2iscsi/be_cmds.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/be2iscsi/be_cmds.c b/drivers/scsi/be2iscsi/be_cmds.c
index 3338391..1ec9793 100644
--- a/drivers/scsi/be2iscsi/be_cmds.c
+++ b/drivers/scsi/be2iscsi/be_cmds.c
@@ -24,9 +24,9 @@
int beiscsi_pci_soft_reset(struct beiscsi_hba *phba)
{
u32 sreset;
- u8 *pci_reset_offset = 0;
- u8 *pci_online0_offset = 0;
- u8 *pci_online1_offset = 0;
+ u8 *pci_reset_offset = NULL;
+ u8 *pci_online0_offset = NULL;
+ u8 *pci_online1_offset = NULL;
u32 pconline0 = 0;
u32 pconline1 = 0;
u32 i;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer
2014-02-21 1:12 [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer Daeseok Youn
@ 2014-03-11 17:02 ` Jayamohan Kallickal
2014-04-08 1:09 ` DaeSeok Youn
0 siblings, 1 reply; 3+ messages in thread
From: Jayamohan Kallickal @ 2014-03-11 17:02 UTC (permalink / raw)
To: Daeseok Youn, JBottomley@parallels.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
-----Original Message-----
From: Daeseok Youn [mailto:daeseok.youn@gmail.com]
Sent: Thursday, February 20, 2014 5:13 PM
To: JBottomley@parallels.com
Cc: Jayamohan Kallickal; linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer
>From b483ef302f7d77c586949ae170754d589e8a4935 Mon Sep 17 00:00:00 2001
From: Daeseok Youn <daeseok.youn@gmail.com>
Date: Fri, 21 Feb 2014 08:39:08 +0900
Subject: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer
sparse says:
drivers/scsi/be2iscsi/be_cmds.c:27:32: warning:
Using plain integer as NULL pointer
drivers/scsi/be2iscsi/be_cmds.c:28:34: warning:
Using plain integer as NULL pointer
drivers/scsi/be2iscsi/be_cmds.c:29:34: warning:
Using plain integer as NULL pointer
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
drivers/scsi/be2iscsi/be_cmds.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/be2iscsi/be_cmds.c b/drivers/scsi/be2iscsi/be_cmds.c index 3338391..1ec9793 100644
--- a/drivers/scsi/be2iscsi/be_cmds.c
+++ b/drivers/scsi/be2iscsi/be_cmds.c
@@ -24,9 +24,9 @@
int beiscsi_pci_soft_reset(struct beiscsi_hba *phba) {
u32 sreset;
- u8 *pci_reset_offset = 0;
- u8 *pci_online0_offset = 0;
- u8 *pci_online1_offset = 0;
+ u8 *pci_reset_offset = NULL;
+ u8 *pci_online0_offset = NULL;
+ u8 *pci_online1_offset = NULL;
u32 pconline0 = 0;
u32 pconline1 = 0;
u32 i;
--
1.7.9.5
Acked-By: Jayamohan Kallickal <jayamohan.kallickal@emulex.com>
--
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer
2014-03-11 17:02 ` Jayamohan Kallickal
@ 2014-04-08 1:09 ` DaeSeok Youn
0 siblings, 0 replies; 3+ messages in thread
From: DaeSeok Youn @ 2014-04-08 1:09 UTC (permalink / raw)
To: JBottomley@parallels.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Jayamohan Kallickal
Hi,
This patch didn't apply. Please check for me.
Thanks.
Daeseok Youn
2014-03-12 2:02 GMT+09:00 Jayamohan Kallickal <Jayamohan.Kallickal@emulex.com>:
>
>
> -----Original Message-----
> From: Daeseok Youn [mailto:daeseok.youn@gmail.com]
> Sent: Thursday, February 20, 2014 5:13 PM
> To: JBottomley@parallels.com
> Cc: Jayamohan Kallickal; linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer
>
> From b483ef302f7d77c586949ae170754d589e8a4935 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <daeseok.youn@gmail.com>
> Date: Fri, 21 Feb 2014 08:39:08 +0900
> Subject: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer
>
> sparse says:
>
> drivers/scsi/be2iscsi/be_cmds.c:27:32: warning:
> Using plain integer as NULL pointer
> drivers/scsi/be2iscsi/be_cmds.c:28:34: warning:
> Using plain integer as NULL pointer
> drivers/scsi/be2iscsi/be_cmds.c:29:34: warning:
> Using plain integer as NULL pointer
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> ---
> drivers/scsi/be2iscsi/be_cmds.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/be2iscsi/be_cmds.c b/drivers/scsi/be2iscsi/be_cmds.c index 3338391..1ec9793 100644
> --- a/drivers/scsi/be2iscsi/be_cmds.c
> +++ b/drivers/scsi/be2iscsi/be_cmds.c
> @@ -24,9 +24,9 @@
> int beiscsi_pci_soft_reset(struct beiscsi_hba *phba) {
> u32 sreset;
> - u8 *pci_reset_offset = 0;
> - u8 *pci_online0_offset = 0;
> - u8 *pci_online1_offset = 0;
> + u8 *pci_reset_offset = NULL;
> + u8 *pci_online0_offset = NULL;
> + u8 *pci_online1_offset = NULL;
> u32 pconline0 = 0;
> u32 pconline1 = 0;
> u32 i;
> --
> 1.7.9.5
>
> Acked-By: Jayamohan Kallickal <jayamohan.kallickal@emulex.com>
>
> --
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-08 1:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-21 1:12 [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer Daeseok Youn
2014-03-11 17:02 ` Jayamohan Kallickal
2014-04-08 1:09 ` DaeSeok Youn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox