Re: [PATCH 5/7] scsi: remove the no_highmem flag in the host

John Garry
2025-05-05T10:14:57Z

On 05/05/2025 09:11, Christoph Hellwig wrote:
> All users are gone now.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Hannes Reinecke <hare@suse.de>

Reviewed-by: John Garry <john.g.garry@oracle.com>

> ---
> drivers/scsi/scsi_lib.c | 3 ---
> include/scsi/scsi_host.h | 2 --
> 2 files changed, 5 deletions(-)
>
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index 0d29470e86b0..39320dccbdd5 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -2000,9 +2000,6 @@ void scsi_init_limits(struct Scsi_Host *shost, struct queue_limits *lim)
> lim->dma_alignment = max_t(unsigned int,
> shost->dma_alignment, dma_get_cache_alignment() - 1);
>
> - if (shost->no_highmem)
> - lim->features |= BLK_FEAT_BOUNCE_HIGH;
> -
> /*
> * Propagate the DMA formation properties to the dma-mapping layer as
> * a courtesy service to the LLDDs. This needs to check that the buses
> diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
> index 26bc23419cfd..c53812b9026f 100644
> --- a/include/scsi/scsi_host.h
> +++ b/include/scsi/scsi_host.h
> @@ -670,8 +670,6 @@ struct Scsi_Host {
> /* The transport requires the LUN bits NOT to be stored in CDB[1] */
> unsigned no_scsi2_lun_in_cdb:1;
>
> - unsigned no_highmem:1;

I note that there are some ancient references to highmem_io around. I
guess that this was the previous name.

> -
> /*
> * Optional work queue to be utilized by the transport
> */