From: Sitsofe Wheeler <sitsofe@yahoo.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
linux-kernel@vger.kernel.org, rjw@sisk.pl,
Ingo Molnar <mingo@elte.hu>,
linux-scsi@vger.kernel.org
Subject: Re: [SCSI][REGRESSION][BISECTED] Disk errors loop forever in 2.6.29
Date: Thu, 19 Feb 2009 16:54:29 -0800 (PST) [thread overview]
Message-ID: <852441.94339.qm@web110616.mail.gq1.yahoo.com> (raw)
In-Reply-To: 1235080134.12500.45.camel@localhost.localdomain
> From: James Bottomley <James.Bottomley@HansenPartnership.com>
>
> Your specific behaviour change seems to be a bug in the way the rewrite
> is handling ABORTED_COMMAND. Could you try the patch below (with or
> without the block patch, it shouldn't matter) and see if it gets you
> back to 2.6.28 behaviour?
Yup that patch makes things timeout quickly just like 2.6.28. The whole
"it didn't used to cache failures" piece in the previous email seems to
have been a fabrication inside my own head - I checked and 2.6.28 caches
the failure until the cache is dropped too.
It might be worth turning your original patch into some sort of warning
stack trace trigger so that people understand it's just there for
unwedging and isn't expected behaviour (it is useful for breaking out of
near lockups though).
Tested-by: Sitsofe Wheeler <sitsofe@yahoo.com>
next prev parent reply other threads:[~2009-02-20 0:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-19 21:11 [SCSI][REGRESSION][BISECTED] Disk errors loop forever in 2.6.29 Sitsofe Wheeler
2009-02-19 21:48 ` James Bottomley
2009-02-20 0:54 ` Sitsofe Wheeler [this message]
[not found] <Pine.LNX.4.44L0.0902191002160.3012-100000@iolanthe.rowland.org>
2009-02-19 16:52 ` Sitsofe Wheeler
2009-02-19 18:41 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=852441.94339.qm@web110616.mail.gq1.yahoo.com \
--to=sitsofe@yahoo.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox