Re: [PATCH 027/117] advansys: Convert to the scsi_status union

Matthew Wilcox
2021-04-20T03:24:08Z

On Mon, Apr 19, 2021 at 08:17:23PM -0700, Bart Van Assche wrote:
> On 4/19/21 6:49 PM, Matthew Wilcox wrote:
> > On Mon, Apr 19, 2021 at 05:07:15PM -0700, Bart Van Assche wrote:
> >> An explanation of the purpose of this patch is available in the patch
> >> "scsi: Introduce the scsi_status union".
> >
> > That is not the correct way to write a changelog.
>
> Thanks for having taken a look. Once there is agreement about the
> approach of this patch series I can write a script that replaces the
> above text with the description it refers to.

... I haven't taken a look. I have no idea what this patch does,
and I can't provide feedback on the approach. Because I haven't seen
the approach. All I've seen is this patch, and the one to sym53c8xx.
Take a look at those patches in isolation -- would you be able to provide
any kind of sensible feedback?