From: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
To: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: axboe@fb.com, linux-block@vger.kernel.org,
Brian King <brking@linux.vnet.ibm.com>,
Douglas Miller <dougmill@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/2] blk-mq: Avoid memory reclaim when remapping queues
Date: Wed, 16 Nov 2016 14:23:18 -0200 [thread overview]
Message-ID: <8737irmm15.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <39a42839-b877-21b7-aa85-314cf499e234@sandisk.com> (Bart Van Assche's message of "Tue, 15 Nov 2016 14:51:30 -0800")
Bart Van Assche <bart.vanassche@sandisk.com> writes:
> I don't think that GFP_NOWAIT is acceptable in this context. Have you
> tried GFP_NOIO instead of GFP_NOWAIT?
At first I used GFP_NOIO, but after reviewing gfp.h I convinced myself
GFP_NOWAIT was what I wanted because I was concerned about FS accesses
that aren't restricted in GFP_NOIO. For some reason, I assumed this was
an issue. I'm ok with the change and can submit a v2 shortly, after
more tests. in fact, this will make the change more compliant with the
rest of block layer critical allocations that use GFP_NOIO.
Thanks,
--
Gabriel Krisman Bertazi
prev parent reply other threads:[~2016-11-16 16:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 19:24 [PATCH 1/2] blk-mq: Fix failed allocation path when mapping queues Gabriel Krisman Bertazi
2016-11-14 19:24 ` [PATCH 2/2] blk-mq: Avoid memory reclaim when remapping queues Gabriel Krisman Bertazi
2016-11-15 22:51 ` Bart Van Assche
2016-11-16 16:23 ` Gabriel Krisman Bertazi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737irmm15.fsf@linux.vnet.ibm.com \
--to=krisman@linux.vnet.ibm.com \
--cc=axboe@fb.com \
--cc=bart.vanassche@sandisk.com \
--cc=brking@linux.vnet.ibm.com \
--cc=dougmill@linux.vnet.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).