Aic7xxx 6.2.28 and Aic79xx 1.3.0 Released

Aic7xxx 6.2.28 and Aic79xx 1.3.0 Released

[Justin T. Gibbs]

GNU patch relative to 2.5.59:
 http://people.FreeBSD.org/~gibbs/linux/SRC/aic79xx-linux-2.5.59-20030122-gnupatch.gz

BK send and tarball distributions:
 http://people.FreeBSD.org/~gibbs/linux/SRC/aic79xx-linux-2.4-20030122.bksend.gz
 http://people.FreeBSD.org/~gibbs/linux/SRC/aic79xx-linux-2.5-20030122.bksend.gz
 http://people.FreeBSD.org/~gibbs/linux/SRC/aic79xx-linux-2.4-20030122-tar.gz
 http://people.FreeBSD.org/~gibbs/linux/SRC/aic79xx-linux-2.5-20030122-tar.gz

Driver update diskettes for most distributions:

	http://people.FreeBSD.org/~gibbs/linux/DUD/aic7xxx/
	http://people.FreeBSD.org/~gibbs/linux/DUD/aic79xx/

RPMs for most distributions:

	http://people.FreeBSD.org/~gibbs/linux/RPM/aic7xxx/
	http://people.FreeBSD.org/~gibbs/linux/RPM/aic79xx/

Changes since the driver versions incorperated in 2.5.59:

ChangeSet@1.961, 2003-01-22 15:09:24-07:00, gibbs@overdrive.btc.adaptec.com
  Bump aic79xx driver version number to 1.3.0, now that it has
  passed functional test.

ChangeSet@1.960, 2003-01-22 14:44:51-07:00, gibbs@overdrive.btc.adaptec.com
  Update Aic7xxx and Aic79xx driver documentation.

ChangeSet@1.959, 2003-01-20 16:46:37-07:00, gibbs@overdrive.btc.adaptec.com
  Aic7xxx Driver Update 6.2.28
        o Add some more DV diagnostic code
        o Fix bug that caused sequencer debug code to be
          downloaded always.

  Aic79xx Driver Update 1.3.0.RC2
        o Correct a regression in RC1 that effectively limited DV to just ID 0.
        o Add some more DV diagnostic code
        o Misc code cleanups.

ChangeSet@1.958, 2003-01-17 14:49:42-07:00, gibbs@overdrive.btc.adaptec.com
  Aic7xxx and Aic79xx Driver Update
        Force an SDTR after a rejected WDTR if the syncrate is unkonwn.

ChangeSet@1.957, 2003-01-17 13:20:53-07:00, gibbs@overdrive.btc.adaptec.com
  Bump aic7xxx driver version to 6.2.27.

ChangeSet@1.956, 2003-01-17 13:17:49-07:00, gibbs@overdrive.btc.adaptec.com
  Aic7xxx Driver Update:
    o Determine more conclusively that a BIOS has initialized the
      adapter before using "left over BIOS settings".
    o Adapt to upcoming removal of cmd->target/channel/lun/host in 2.5.X
    o Fix a memory leak on driver unload.
    o Enable the pci_parity command line option and default to pci parity
      error detection *disabled*.  There are just too many broken VIA
      chipsets out there.
    o Move more functionality into aiclib to share with the aic79xx driver.
    o Correct a few negotiation regressions.
    o Don't bother doing full DV on devices that only support async transfers.
      This should fix a few more of the reported problems with DV.

  Aic79xx Driver Update
    o Add abort and bus device reset handlers.
    o Fix a memory leak on driver unload.
    o Adapt to upcoming removal of cmd->target/channel/lun/host in 2.5.X.
    o Correct a few negotiation regressions.

ChangeSet@1.955, 2003-01-17 12:18:22-07:00, gibbs@overdrive.btc.adaptec.com
  Aic79xx Driver Update
        Enable abort and bus device reset handlers for both legacy
        and packetized connections.

ChangeSet@1.954, 2003-01-17 12:10:23-07:00, gibbs@overdrive.btc.adaptec.com
  Aic7xxx and Aic79xx DV Fix:
        Don't bother with DV if the device can only do async

Re: Aic7xxx 6.2.28 and Aic79xx 1.3.0 Released

[Denis Vlasenko]

On 23 January 2003 00:50, Justin T. Gibbs wrote:
> GNU patch relative to 2.5.59:
> 
> http://people.FreeBSD.org/~gibbs/linux/SRC/aic79xx-linux-2.5.59-20030
>122-gnupatch.gz

I didn't track your development efforts too closely...
does this mean that latest 2.4 (2.4.20?) will detect my oldie 7782?

On 24 October 2002 15:45, Denis Vlasenko wrote:
> > > The problem is that it does not see its disks when I boot Linux.
> > > Currently I'm running it in NFS root mode, but 16MB RAM is not
> > > much fun without swap :(
> > >
> > > I'd like to stick printks here and there in driver source,
> > > thought you may have some advice.
> >
> > Since you seem to have enabled the EISA/VLB probe in your config,
> > I don't know why your controller is not probed.
>
> I sticked some printks in the code, here is a new syslog output
> (diff with printks is at the end).
--
vda

Re: Aic7xxx 6.2.28 and Aic79xx 1.3.0 Released

[Justin T. Gibbs]

> On 23 January 2003 00:50, Justin T. Gibbs wrote:
>> GNU patch relative to 2.5.59:
>> 
>> http://people.FreeBSD.org/~gibbs/linux/SRC/aic79xx-linux-2.5.59-20030
>> 122-gnupatch.gz
> 
> I didn't track your development efforts too closely...
> does this mean that latest 2.4 (2.4.20?) will detect my oldie 7782?

The Olvetti EISA IDs have been included since 6.2.24?? or so.

--
Justin

Re: Aic7xxx 6.2.28 and Aic79xx 1.3.0 Released

[David S. Miller]

On Wed, 2003-01-22 at 14:50, Justin T. Gibbs wrote:
> GNU patch relative to 2.5.59:
>  http://people.FreeBSD.org/~gibbs/linux/SRC/aic79xx-linux-2.5.59-20030122-gnupatch.gz

Justin, I haven't checked, but have you deleted my change
again to include asm/io.h in aix7xxx_osm.h?

You keep doing this, I wish you'd stop :-)

More seriously, you really need to look at the build etc.
fixes people put into your driver in 2.5.x, it is rude to
keep deleting such changes over and over again.

Re: Aic7xxx 6.2.28 and Aic79xx 1.3.0 Released

[Justin T. Gibbs]

> On Wed, 2003-01-22 at 14:50, Justin T. Gibbs wrote:
>> GNU patch relative to 2.5.59:
>>  http://people.FreeBSD.org/~gibbs/linux/SRC/aic79xx-linux-2.5.59-2003012
>>  2-gnupatch.gz
> 
> Justin, I haven't checked, but have you deleted my change
> again to include asm/io.h in aix7xxx_osm.h?
> 
> You keep doing this, I wish you'd stop :-)

I wish you'd actually look at the changes before assuming
what they do and don't contain.

--
Justin

Re: Aic7xxx 6.2.28 and Aic79xx 1.3.0 Released

[David S. Miller]

   From: "Justin T. Gibbs" <gibbs@scsiguy.com>
   Date: Thu, 23 Jan 2003 20:45:05 -0700

   > You keep doing this, I wish you'd stop :-)
   
   I wish you'd actually look at the changes before assuming
   what they do and don't contain.
   
You deleted my change on at least two occaisions.
If you've stopped doing that, great.

Re: Aic7xxx 6.2.28 and Aic79xx 1.3.0 Released

[Justin T. Gibbs]

>    From: "Justin T. Gibbs" <gibbs@scsiguy.com>
>    Date: Thu, 23 Jan 2003 20:45:05 -0700
> 
>    > You keep doing this, I wish you'd stop :-)
>    
>    I wish you'd actually look at the changes before assuming
>    what they do and don't contain.
>    
> You deleted my change on at least two occaisions.
> If you've stopped doing that, great.

And when it happened the first time, you didn't bother to tell
me?  Why?  So you could act slighted later?

If you really care to have an update *stick* to a piece of externally
maintained software, pass your changes through the maintainer.  That is
only reasonable.

There have been lots of changes to the driver that I have merged back
manually and lots that I have tossed as incorrect and should never have
been accepted by Linus in the first place.  In your case, the change was
small *and* incomplete (you didn't update the aic79xx driver), so it was
missed during a few of my merges.  If you had simply bothered to send me
email when you submitted the change to Linus (you seem to know my email
address and that I maintain the driver) both drivers would have had this
change long ago.

And yes, both drivers, as of this drop, now include asm/io.h.

--
Justin

Re: Aic7xxx 6.2.28 and Aic79xx 1.3.0 Released

[David S. Miller]

   From: "Justin T. Gibbs" <gibbs@scsiguy.com>
   Date: Thu, 23 Jan 2003 20:56:38 -0700
  
   And when it happened the first time, you didn't bother to tell
   me?  Why?  So you could act slighted later?

Because it is your duty as maintainer to watch what changes
(especially build fixes) go into Linus's and Marcelo's tree.

Re: Aic7xxx 6.2.28 and Aic79xx 1.3.0 Released

[Justin T. Gibbs]

>    From: "Justin T. Gibbs" <gibbs@scsiguy.com>
>    Date: Thu, 23 Jan 2003 20:56:38 -0700
>   
>    And when it happened the first time, you didn't bother to tell
>    me?  Why?  So you could act slighted later?
> 
> Because it is your duty as maintainer to watch what changes
> (especially build fixes) go into Linus's and Marcelo's tree.

That's like saying that its Linus's or Marcelo's responsibility
to catch whether you or anyone else submits a bogus/broken change
to their tree.  Nobody catches everything all the time and mistakes,
bugs, etc. get merged into 2.4.X and 2.5.X every day.  Such is life,
especially in a volunteer project where nobody has a duty or
reponsibility to do anything at all.

If a change or bugfix to my driver is important to you, send it to
me and it will not get missed.  That's what everyone except you does,
and interestingly enough, you are the only one complaining. 8-)

--
Justin

Re: Aic7xxx 6.2.28 and Aic79xx 1.3.0 Released

[David S. Miller]

   From: "Justin T. Gibbs" <gibbs@scsiguy.com>
   Date: Thu, 23 Jan 2003 21:26:36 -0700

   > Because it is your duty as maintainer to watch what changes
   > (especially build fixes) go into Linus's and Marcelo's tree.
   
   That's like saying that its Linus's or Marcelo's responsibility
   to catch whether you or anyone else submits a bogus/broken change
   to their tree.

Your driver update broke the build of Linus's tree, so I sent Linus
a change that fixed the build.

And in fact, you are describing exactly what Linus and Marcelo's
jobs are, to reject bogus/broken changes.

Re: Aic7xxx 6.2.28 and Aic79xx 1.3.0 Released

[Justin T. Gibbs]

> And in fact, you are describing exactly what Linus and Marcelo's
> jobs are, to reject bogus/broken changes.

I think you missed the subtely of what I said.  It's not "their duty"
to never make a mistake, and it is not expected that they will catch
everything.  When they do miss something, or make a mistake you probably
tell them in a straight forward fashion.  In this case, what you
effectively said to me was:

	"Hey.  I would appreciate it if you would stop not
	 noticing this change that I made to your code through
	 Linus without telling you. *Twice* no less.  Wake up!
	 Wasn't it obvious?  It is *your duty* to notice these
	 one line changes that happen to break the build on
	 a platform that I care about but doesn't have any
	 consequences on the platforms you are probably testing.
	 Oh, and the aic79xx driver... well I didn't bother to
	 look at that because it's not in my configuration.
	 Oh well."

And I get all of this grief *after* I already included the change
instead of after the first time I missed it.  You really make me
laugh!

--
Justin

Re: Aic7xxx 6.2.28 and Aic79xx 1.3.0 Released

[David S. Miller]

   From: "Justin T. Gibbs" <gibbs@scsiguy.com>
   Date: Thu, 23 Jan 2003 21:54:37 -0700
   
   You really make me laugh!

I'm glad that we've established that we both provide endless amounts
of comedy for each other.

Look Justin, the fact remains that you get paid top dollar to maintain
the Linux Adaptec driver.  If you can't be bothered to reliably
integrate fixes that show up in Linus's and Marcelo's tree, then
that's regretfully sad given your circumstances.

Now that is what makes me laugh!