From: Rusty Russell <rusty@rustcorp.com.au>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: module: fix module_refcount() return when running in a module exit routine
Date: Wed, 21 Jan 2015 16:00:29 +1030 [thread overview]
Message-ID: <877fwgbszu.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1421774615.2080.88.camel@HansenPartnership.com>
James Bottomley <James.Bottomley@HansenPartnership.com> writes:
> Actually, I don't think this is enough. Some Australian once came up
> with a guide to APIs, and lectured on it at length, one of which was
> that the name should be the obvious use and it is unexpected that a
> refcount would go negative. I think we could raise it from -6 on the
> API scale to +3 if we add some documentation like below.
Thanks, applied!
Cheers,
Rusty.
next prev parent reply other threads:[~2015-01-21 23:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-18 16:55 module: fix module_refcount() return when running in a module exit routine James Bottomley
2015-01-18 23:37 ` Rusty Russell
2015-01-19 5:18 ` Masami Hiramatsu
2015-01-19 5:51 ` Rusty Russell
2015-01-19 8:28 ` Christoph Hellwig
2015-01-19 16:07 ` James Bottomley
2015-01-19 16:08 ` James Bottomley
2015-01-20 0:45 ` Rusty Russell
2015-01-20 2:17 ` Masami Hiramatsu
2015-01-20 17:23 ` James Bottomley
2015-01-21 5:30 ` Rusty Russell [this message]
2015-01-22 16:50 ` Christoph Hellwig
2015-01-22 17:02 ` James Bottomley
2015-01-23 2:54 ` Rusty Russell
2015-01-23 13:17 ` Christoph Hellwig
2015-01-23 18:42 ` James Bottomley
2015-01-23 23:35 ` Rusty Russell
2015-01-26 17:16 ` Christoph Hellwig
2015-01-28 9:23 ` Bart Van Assche
2015-01-28 21:45 ` James Bottomley
2015-01-29 12:16 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fwgbszu.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).