public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Philippe Troin <phil@fifi.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: James Bottomley <James.Bottomley@steeleye.com>,
	USB Storage list <usb-storage@lists.one-eyed-alien.net>,
	SCSI development list <linux-scsi@vger.kernel.org>
Subject: Re: iRiver H100 series and usb-storage issues
Date: 07 Jun 2004 12:43:02 -0700	[thread overview]
Message-ID: <87brjvw3w9.fsf@ceramic.fifi.org> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0406071040310.1800-100000@ida.rowland.org>

Alan Stern <stern@rowland.harvard.edu> writes:

> I just noticed this thread on linux-kernel:
> 
> http://marc.theaimsgroup.com/?l=linux-kernel&m=108372064000188&w=2
> 
> Apparently under some circumstances the iRiver H100 returns 0 bytes 
> transferred with GOOD status and residue=512 for a READ(10) command 
> asking for 1 sector.  As far as I know this is legal, and it indicates the 
> command should simply be retried.

That's correct.  However, the iRiver H1xx will also commit a USB
protocol violation by not returning a CSW (Command Status
Wrapper).  That's what screws up the transfer.
 
> But apparently the sd driver doesn't realize what has happened and assumes 
> the transfer was successful.  If I'm right then the sd driver should be 
> fixed, but I'm not sure what is the best thing to do.

I am not sure the SCSI layer can recover given that the USB layer is
confused...

Please note that:

 1. I am just repeating what I have been told by various people and
    claim no knowledge of the USB or SCSI layers.  In other words, I
    could be all wrong :-)

 2. I do not own a H1xx anymore, having returned mine.
 
Phil.

  reply	other threads:[~2004-06-07 19:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-29 23:42 Patch for iriver-mp3player Tobias Lieber
2004-06-06 14:48 ` James Bottomley
2004-06-06 22:32   ` Matthew Dharm
2004-06-07 14:36     ` Alan Stern
2004-06-28 19:42       ` Tobias Lieber
2004-06-07 14:47   ` iRiver H100 series and usb-storage issues Alan Stern
2004-06-07 19:43     ` Philippe Troin [this message]
2004-06-07 20:22       ` Alan Stern
2004-06-07 21:18         ` Philippe Troin
2004-06-07 22:27           ` [usb-storage] " Pat LaVarre
2004-06-08 14:24             ` Alan Stern
2004-06-08 15:52               ` James Bottomley
2004-06-08 16:10                 ` Pat LaVarre
2004-06-08 16:16                   ` James Bottomley
2004-06-08 17:01                     ` Mike Anderson
2004-06-08 14:19           ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87brjvw3w9.fsf@ceramic.fifi.org \
    --to=phil@fifi.org \
    --cc=James.Bottomley@steeleye.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=usb-storage@lists.one-eyed-alien.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox