* [PATCH 2/2] ipr: Remove redundant messages at adapter init time
@ 2016-09-16 21:51 Brian King
2016-09-16 22:00 ` Gabriel Krisman Bertazi
2016-09-19 15:59 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Brian King @ 2016-09-16 21:51 UTC (permalink / raw)
To: James.Bottomley; +Cc: martin.petersen, linux-scsi, krisman, wenxiong, brking
Whenever multiple HRRQs are enabled, which is the default
setting now, we end up seeing the following message logged
prior to initialization of each HRRQ:
Starting IOA initialization sequence
This results in 16 of these messages on most adapters, which
serves little purpose. Change to just log this once.
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
---
drivers/scsi/ipr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -puN drivers/scsi/ipr.c~ipr_hrrq_message drivers/scsi/ipr.c
--- linux-2.6.git/drivers/scsi/ipr.c~ipr_hrrq_message 2016-08-30 20:53:06.909099536 -0500
+++ linux-2.6.git-bjking1/drivers/scsi/ipr.c 2016-08-30 20:53:06.915099497 -0500
@@ -8049,7 +8049,8 @@ static int ipr_ioafp_identify_hrrq(struc
ENTER;
ipr_cmd->job_step = ipr_ioafp_std_inquiry;
- dev_info(&ioa_cfg->pdev->dev, "Starting IOA initialization sequence.\n");
+ if (ioa_cfg->identify_hrrq_index == 0)
+ dev_info(&ioa_cfg->pdev->dev, "Starting IOA initialization sequence.\n");
if (ioa_cfg->identify_hrrq_index < ioa_cfg->hrrq_num) {
hrrq = &ioa_cfg->hrrq[ioa_cfg->identify_hrrq_index];
_
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 2/2] ipr: Remove redundant messages at adapter init time
2016-09-16 21:51 [PATCH 2/2] ipr: Remove redundant messages at adapter init time Brian King
@ 2016-09-16 22:00 ` Gabriel Krisman Bertazi
2016-09-19 15:59 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Gabriel Krisman Bertazi @ 2016-09-16 22:00 UTC (permalink / raw)
To: Brian King; +Cc: James.Bottomley, martin.petersen, linux-scsi, wenxiong
Brian King <brking@linux.vnet.ibm.com> writes:
> Whenever multiple HRRQs are enabled, which is the default
> setting now, we end up seeing the following message logged
> prior to initialization of each HRRQ:
>
> Starting IOA initialization sequence
>
> This results in 16 of these messages on most adapters, which
> serves little purpose. Change to just log this once.
Reviewed-by: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
--
Gabriel Krisman Bertazi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] ipr: Remove redundant messages at adapter init time
2016-09-16 21:51 [PATCH 2/2] ipr: Remove redundant messages at adapter init time Brian King
2016-09-16 22:00 ` Gabriel Krisman Bertazi
@ 2016-09-19 15:59 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2016-09-19 15:59 UTC (permalink / raw)
To: Brian King
Cc: James.Bottomley, martin.petersen, linux-scsi, krisman, wenxiong
>>>>> "Brian" == Brian King <brking@linux.vnet.ibm.com> writes:
Brian> Whenever multiple HRRQs are enabled, which is the default setting
Brian> now, we end up seeing the following message logged prior to
Brian> initialization of each HRRQ:
Brian> Starting IOA initialization sequence
Brian> This results in 16 of these messages on most adapters, which
Brian> serves little purpose. Change to just log this once.
Applied to 4.9/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-19 15:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-16 21:51 [PATCH 2/2] ipr: Remove redundant messages at adapter init time Brian King
2016-09-16 22:00 ` Gabriel Krisman Bertazi
2016-09-19 15:59 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).