From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Maurizio Lombardi <mlombard@redhat.com>
Cc: Tejun Heo <tj@kernel.org>,
joe@perches.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, dgilbert@interlog.com
Subject: Re: [RFC PATCH 0/3] fix *pbl format support
Date: Mon, 21 Sep 2015 18:24:13 +0200 [thread overview]
Message-ID: <87fv27lp02.fsf@rasmusvillemoes.dk> (raw)
In-Reply-To: <56001A43.6050501@redhat.com> (Maurizio Lombardi's message of "Mon, 21 Sep 2015 16:54:59 +0200")
On Mon, Sep 21 2015, Maurizio Lombardi <mlombard@redhat.com> wrote:
> Hi Rasmus,
>
> On 09/16/2015 10:35 PM, Rasmus Villemoes wrote:
>>
>> I just remembered: I noticed a while ago that the qualifier member is
>> only used inside format_decode (in the end, the information is folded
>> into the type member), so one might as well use a local variable for
>> that. This gives option (3): Make field_width a 24 bit bitfield. I think
>> that should be sufficient for any realistic bitmap that one would
>> print. The patch is also rather small. Surprisingly, bloat-o-meter even
>> says that it's also a net win in code size:
>
> I tested your patch with scsi-debug and it works for me:
Thanks for testing it! What do people think of this option?
Rasmus
prev parent reply other threads:[~2015-09-21 16:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1442394523-19176-1-git-send-email-mlombard@redhat.com>
[not found] ` <87d1xi4kic.fsf@rasmusvillemoes.dk>
[not found] ` <20150916174536.GE3243@mtj.duckdns.org>
[not found] ` <877fnq2jc0.fsf@rasmusvillemoes.dk>
2015-09-21 14:54 ` [RFC PATCH 0/3] fix *pbl format support Maurizio Lombardi
2015-09-21 16:24 ` Rasmus Villemoes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fv27lp02.fsf@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=dgilbert@interlog.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mlombard@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox