From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A375AC41513 for ; Mon, 31 Jul 2023 20:41:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229727AbjGaUlb (ORCPT ); Mon, 31 Jul 2023 16:41:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229535AbjGaUla (ORCPT ); Mon, 31 Jul 2023 16:41:30 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FC55E75; Mon, 31 Jul 2023 13:41:29 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1690836088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BTxPMB3V133cgzwz17m6DmWwRtesGt+jhqpdIH5ALoQ=; b=0G8BQSRxV7478DeJ/esCuK54evV9NQCPC4ID96ymAA03ofm8kvZ4nsCn+DSgeW8XJsJY8W zq+UbN2szW1PdZUdeqsbf36Zf7VLeoc4xsqb8PJ+iBS2a0D0IbQO+j1XWWCQrDosRG3Ryi IQW4zSl88x4G+daZbw5QVfdTPYrwM9RWEOqrIvQh0cWhcVTsMVZ0lUlJGeNE/chKw4FY9p g65UGbWCbjfotggxaInr71hJBvC1Ny43kpiio468+BQwCCC4rTesKnIlouhjuqAFlcP693 QrvjJtK35uy1mUdxLSDHT3KtzKBMe8hU8Iys9QYd+yqqXpbtMgNCHmo2/8DKCQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1690836088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BTxPMB3V133cgzwz17m6DmWwRtesGt+jhqpdIH5ALoQ=; b=/FhSHnIwquFqCkm7XmxX3HCzSElSAB8dpvKfGEw71LcWF5A9ynlFHoO5mKwt/pnm9jEBod QbfR97sGl4l9hnAg== To: "Michael Kelley (LINUX)" , LKML Cc: "x86@kernel.org" , Tom Lendacky , Andrew Cooper , Arjan van de Ven , "James E.J. Bottomley" , Dick Kennedy , James Smart , "Martin K. Petersen" , "linux-scsi@vger.kernel.org" , Guenter Roeck , "linux-hwmon@vger.kernel.org" , Jean Delvare , Huang Rui , Juergen Gross , Steve Wahl , Mike Travis , Dimitri Sivanich , Russ Anderson Subject: RE: [patch v2 21/38] x86/cpu: Provide cpu_init/parse_topology() In-Reply-To: References: <20230728105650.565799744@linutronix.de> <20230728120930.839913695@linutronix.de> <871qgop8dc.ffs@tglx> Date: Mon, 31 Jul 2023 22:41:27 +0200 Message-ID: <87jzufn79k.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Mon, Jul 31 2023 at 16:25, Michael Kelley wrote: > From: Thomas Gleixner Sent: Monday, July 31, 2023 5:35 AM >> Define bogus. MADT is the primary source of information because that's >> how we know how many CPUs (APICs) are there and what their APIC ID is >> which we can use to wake them up. So there is a reasonable expectation >> that this information is consistent with the rest of the system. > > Commit d49597fd3bc7 "x86/cpu: Deal with broken firmware (VMWare/Xen)" > mentions VMware and XEN implementations that violate the spec. The > commit is from late 2016. Have these bad systems aged out and no longer > need accommodation? They do, but this commit explicitely uses the MADT/real APIC ID value: c->initial_apicid = apicid; So the new mechanics are accomodating for those, right? Thanks, tglx