[PATCH 1/2] ipr: Don't log unnecessary 9084 error details

[PATCH 1/2] ipr: Don't log unnecessary 9084 error details

[Brian King]

A 9084 error gets logged by the ipr adapter when adapter raw mode
gets enabled. A bunch of unformatted hex data also gets logged
for this error, which is of little use, so let's avoid logging
it by default in order to avoid the log getting polluted with
useless data.

Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
---

 drivers/scsi/ipr.c |    6 +++---
 drivers/scsi/ipr.h |    1 +
 2 files changed, 4 insertions(+), 3 deletions(-)

diff -puN drivers/scsi/ipr.c~ipr_9084 drivers/scsi/ipr.c
--- linux-2.6.git/drivers/scsi/ipr.c~ipr_9084	2016-09-06 21:01:10.423275926 -0500
+++ linux-2.6.git-bjking1/drivers/scsi/ipr.c	2016-09-09 16:03:44.639230433 -0500
@@ -493,15 +493,15 @@ struct ipr_error_table_t ipr_error_table
 	"9072: Link not operational transition"},
 	{0x066B8200, 0, IPR_DEFAULT_LOG_LEVEL,
 	"9032: Array exposed but still protected"},
-	{0x066B8300, 0, IPR_DEFAULT_LOG_LEVEL + 1,
+	{0x066B8300, 0, IPR_DEBUG_LOG_LEVEL,
 	"70DD: Device forced failed by disrupt device command"},
 	{0x066B9100, 0, IPR_DEFAULT_LOG_LEVEL,
 	"4061: Multipath redundancy level got better"},
 	{0x066B9200, 0, IPR_DEFAULT_LOG_LEVEL,
 	"4060: Multipath redundancy level got worse"},
-	{0x06808100, 0, IPR_DEFAULT_LOG_LEVEL,
+	{0x06808100, 0, IPR_DEBUG_LOG_LEVEL,
 	"9083: Device raw mode enabled"},
-	{0x06808200, 0, IPR_DEFAULT_LOG_LEVEL,
+	{0x06808200, 0, IPR_DEBUG_LOG_LEVEL,
 	"9084: Device raw mode disabled"},
 	{0x07270000, 0, 0,
 	"Failure due to other device"},
diff -puN drivers/scsi/ipr.h~ipr_9084 drivers/scsi/ipr.h
--- linux-2.6.git/drivers/scsi/ipr.h~ipr_9084	2016-09-09 16:01:52.072645477 -0500
+++ linux-2.6.git-bjking1/drivers/scsi/ipr.h	2016-09-09 16:02:27.685197801 -0500
@@ -1506,6 +1506,7 @@ struct ipr_ioa_cfg {
 	u8 log_level;
 #define IPR_MAX_LOG_LEVEL			4
 #define IPR_DEFAULT_LOG_LEVEL		2
+#define IPR_DEBUG_LOG_LEVEL		3
 
 #define IPR_NUM_TRACE_INDEX_BITS	8
 #define IPR_NUM_TRACE_ENTRIES		(1 << IPR_NUM_TRACE_INDEX_BITS)
_

Re: [PATCH 1/2] ipr: Don't log unnecessary 9084 error details

[Gabriel Krisman Bertazi]

Brian King <brking@linux.vnet.ibm.com> writes:

> A 9084 error gets logged by the ipr adapter when adapter raw mode
> gets enabled. A bunch of unformatted hex data also gets logged
> for this error, which is of little use, so let's avoid logging
> it by default in order to avoid the log getting polluted with
> useless data.
>

Thanks, Brian.

Reviewed-by: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>



-- 
Gabriel Krisman Bertazi

Re: [PATCH 1/2] ipr: Don't log unnecessary 9084 error details

[Martin K. Petersen]

>>>>> "Brian" == Brian King <brking@linux.vnet.ibm.com> writes:

Brian> A 9084 error gets logged by the ipr adapter when adapter raw mode
Brian> gets enabled. A bunch of unformatted hex data also gets logged
Brian> for this error, which is of little use, so let's avoid logging it
Brian> by default in order to avoid the log getting polluted with
Brian> useless data.

Applied to 4.9/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering