Re: [PATCH 4/4] cdrom: revert commit 22a9189 (cdrom: use kmalloced buffers instead of buffers on stack)

Jim Paris
2008-05-20T07:42:04Z

Elias Oltmanns wrote:
> > + char buffer[255];
> > int ret;
> >
> > - buffer = kmalloc(255, GFP_KERNEL);
> > - if (!buffer)
> > - return -ENOMEM;
> > -
> > - init_cdrom_command(&cgc, buffer, 4, CGC_DATA_READ);
> > + init_cdrom_command(&cgc, &buffer, 4, CGC_DATA_READ);
> ^
> Careful here.

They're the same in C.

-jim