From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Subject: Re: [-next PATCH 3/4] treewide: Use DEVICE_ATTR_RO Date: Wed, 20 Dec 2017 22:38:22 +0100 Message-ID: <87tvwlcc6p.fsf@belgarion.home> References: <2e64e7d278fa9e4e255221fb84717884a7bfb69c.1513706701.git.joe@perches.com> <5619005.tOTWM00GFv@aspire.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5619005.tOTWM00GFv@aspire.rjw.lan> (Rafael J. Wysocki's message of "Wed, 20 Dec 2017 20:00:43 +0100") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Joe Perches Cc: Don Brace , linux-nvme@lists.infradead.org, Rich Felker , linux-sh@vger.kernel.org, David Airlie , esc.storagedev@microsemi.com, Joonas Lahtinen , Heiko Carstens , alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, Jaroslav Kysela , Keith Busch , Russell King , Christoph Hellwig , devel@driverdev.osuosl.org, linux-s390@vger.kernel.org, "James E.J. Bottomley" , Sagi Grimberg , Yoshinor i Sato , Takashi Iwai , Sebastian Ott , James Smart , linux-acpi@vger.kernel.org, Zhang Rui , Len Brown List-Id: linux-scsi@vger.kernel.org "Rafael J. Wysocki" writes: > On Tuesday, December 19, 2017 7:15:08 PM CET Joe Perches wrote: >> Convert DEVICE_ATTR uses to DEVICE_ATTR_RO where possible. >> >> Done with perl script: >> >> $ git grep -w --name-only DEVICE_ATTR | \ >> xargs perl -i -e 'local $/; while (<>) { s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(?:\s*S_IRUGO\s*|\s*0444\s*)\)?\s*,\s*\1_show\s*,\s*NULL\s*\)/DEVICE_ATTR_RO(\1)/g; print;}' >> >> Signed-off-by: Joe Perches >> --- >> arch/arm/mach-pxa/sharpsl_pm.c | 4 ++-- For mach-pxa: Acked-by: Robert Jarzmik Cheers. -- Robert