Re: [PATCH] Documentation: add exception capture function

[Jonathan Corbet <Corbet@lwn.net>]

shijm <junming@nfschina.com> writes:

> Add exception capture function
>
> Signed-off-by: shijm <junming@nfschina.com>

This says what you are doing but not why; nobody has felt the need to
mess with this script for a while; why do we need to change it now?

>  Documentation/target/tcm_mod_builder.py | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/target/tcm_mod_builder.py b/Documentation/target/tcm_mod_builder.py
> index 54492aa813b9..5b28d50ed80f 100755
> --- a/Documentation/target/tcm_mod_builder.py
> +++ b/Documentation/target/tcm_mod_builder.py
> @@ -29,8 +29,9 @@ def tcm_mod_create_module_subdir(fabric_mod_dir_var):
>  		return 1
>  
>  	print "Creating fabric_mod_dir: " + fabric_mod_dir_var
> -	ret = os.mkdir(fabric_mod_dir_var)
> -	if ret:
> +    try:
> +	    ret = os.mkdir(fabric_mod_dir_var)
> +	except:
>  		tcm_mod_err("Unable to mkdir " + fabric_mod_dir_var)

Bare "except" clauses are generally a bad idea in my exception; I assume
you want to catch IOError here?

Assuming that this script is still useful, we should consider moving it
to tools/.

Thanks,

jon