Re: [PATCH] mpt3sas: add NULL check in _base_fault_reset_work()

[Sven Schnelle <svens@stackframe.org>]

Hi Martin,

"Martin K. Petersen" <martin.petersen@oracle.com> writes:

>> My HP C8000 (an PA-RISC based system) crashed with an HPMC. That
>> triggered the HPMC handler in the kernel, and i got a crash in
>> _base_fault_reset_work() from mpt3sas. It looks like this function
>> calls ioc->schedule_dead_ioc_flush_running_cmds() without checking
>> whether there's actually a function set, so it dereferences a NULL
>> pointer on that system. The c8000 actually uses the mptspi driver
>> instead of mpt3sas which doesn't seem to set this handler.
>
> I'm not sure how you end up in the mpt3sas driver if your system uses
> mptspi!?
>
> Can you please send us the HPMC and the output of lspci?

It doesn't end up in mpt3sas, i was just confused because
schedule_dead_ioc_flush_running_cmds() exist also there. If you look at
the diff, you see that i patched the mptspi driver. So the description
is just wrong, sorry.

I'll try to see whether i can reproduce it once more, but the question
still is whether the if () check is okay, or whether that needs more
work (i.e., a handler for that)

Regards
Sven