From: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
To: Brian King <brking@linux.vnet.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Heitor Ricardo Alves de Siqueira <halves@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org,
Heitor Ricardo Alves de Siqueira <hrasiq@gmail.com>
Subject: Re: [PATCHv2] ipr: Add asynchronous error notification
Date: Thu, 25 Aug 2016 12:29:04 -0300 [thread overview]
Message-ID: <87zio098an.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <a7eec861-46e1-4d82-1361-ae9b9a04cf3d@linux.vnet.ibm.com> (Brian King's message of "Wed, 24 Aug 2016 12:56:51 -0500")
Brian King <brking@linux.vnet.ibm.com> writes:
> Looks pretty good. I noticed one issue in an error path where you
> weren't removing the new sysfs file. Here is a fixed version.
>
The modifications look good to me.
--
Gabriel Krisman Bertazi
next prev parent reply other threads:[~2016-08-25 15:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 12:39 [PATCH] ipr: Add asynchronous error notification Heitor Ricardo Alves de Siqueira
2016-08-19 2:47 ` Martin K. Petersen
2016-08-24 17:56 ` [PATCHv2] " Brian King
2016-08-25 15:29 ` Gabriel Krisman Bertazi [this message]
2016-08-26 2:47 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zio098an.fsf@linux.vnet.ibm.com \
--to=krisman@linux.vnet.ibm.com \
--cc=brking@linux.vnet.ibm.com \
--cc=halves@linux.vnet.ibm.com \
--cc=hrasiq@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).